Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small Nix shell for development #615

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

vreuter
Copy link
Contributor

@vreuter vreuter commented Jun 25, 2024

No description provided.

@vreuter vreuter requested a review from a team as a code owner June 25, 2024 12:54
@ybasket
Copy link
Collaborator

ybasket commented Jun 25, 2024

Looks like a cool addition! Could you add a small usage note to the Readme though for discoverability and for people with little Nix experience like me?

@satabin
Copy link
Member

satabin commented Jun 25, 2024

Maybe we could go further and take the Typelevel nix flake. WDYT?

@vreuter
Copy link
Contributor Author

vreuter commented Jun 26, 2024

Maybe we could go further and take the Typelevel nix flake. WDYT?

@satabin I took the typelevel-nix snippet and just removed the sbt microsites section and switched the JDK to from 8 to 11. WDYT? Should there be other modifications of the typelevel base?

Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested on macOS with fresh Nix install and it worked fine 👍

PS: Please avoid force pushes once a PR is open, makes review harder.

@vreuter
Copy link
Contributor Author

vreuter commented Jun 26, 2024

PS: Please avoid force pushes once a PR is open, makes review harder.

Sorry @ybasket , duly noted 😬

Copy link
Member

@satabin satabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

@satabin satabin merged commit cafc4c7 into gnieh:main Jul 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants