Update dependencies, add Scala Native support for circe integration, add jsoniter-scala integration #7

plokhotnyuk · 2022-09-19T08:42:09Z

Close #6 by adding jsoniter-scala module

@ybasket @satabin Can I use code from this PR in a tutorial for jsoniter-scala?

ybasket · 2022-09-19T09:06:06Z

@plokhotnyuk thank you for contributing! I unfortunately don't have the time right now to dive deep into how the codecs work, but it looks good at first glance and I'll try to find some time soon-ish if @satabin isn't faster.

As for using the code in a tutorial, no objections from my side, looking forward to read it. A link back to geo-scala would of course be appreciated :)

…add jsoniter-scala integration

plokhotnyuk · 2022-09-19T09:29:09Z

@ybasket Please approve the workflow run, I hope the latest commit will fix CI build failures

ybasket · 2022-09-19T09:34:20Z

@ybasket Please approve the workflow run, I hope the latest commit will fix CI build failures

Done. Sorry, we probably should have updated after the last release (still learning the details of sbt-typelevel).

Edit: Seems as it wants x.y, just changed that 🤞

build.sbt

plokhotnyuk · 2022-09-19T10:24:42Z

@ybasket Thanks for the help! Please approve the workflow run again, I hope it will show the green mark finally.

plokhotnyuk · 2022-09-19T10:48:47Z

Ups, it failed again... Now looking a way how to generate CI scripts with Java 11 for the jsoniterScala module...

build.sbt

armanbilge · 2022-09-19T11:28:47Z

A workaround to build Java 8 bytecode using Java 11

Just to clarify—it not only builds Java 8 bytecode, it also restricts compilation to use only JDK 8 APIs and nothing newer.

plokhotnyuk · 2022-09-19T11:29:55Z

@armanbilge Thank you a lot! It looks like a clear solution (not a workaround) isn't it?

armanbilge · 2022-09-19T11:32:06Z

Yes, I would consider it to be a solution. In fact there is a proposal to make a configuration like this the default for the next major release of sbt-typelevel.

Java 8 in CI: the end is nigh typelevel/sbt-typelevel#215

plokhotnyuk · 2022-09-19T14:00:48Z

Thank you, @ybasket! I missed to run the githubWorkflowGenerate task again

armanbilge · 2022-09-19T14:06:45Z

Btw, I think this can be removed:

geo-scala/build.sbt

Lines 30 to 32 in 876e75c

    
           // disable MiMa until we have proper version released on gnieh / all platforms 
        
           // once removed, the tlBaseVersion has to adjusted as well 
        
           mimaPreviousArtifacts := Set.empty

armanbilge · 2022-09-19T14:08:55Z

Note: you should never set mimaPreviousArtifacts := Set.empty. This is wrong. You always fall into one of two scenarios:

You are not publishing that module. So .enablePlugins(NoPublishPlugin).
It is a brand new artifact, not yet published. So set

  tlVersionIntroduced := Map("2.12" -> "1.2.3", "2.13" -> "1.2.3", "3" -> "1.2.3")

Assuming that 1.2.3 is the first version it will be published in.

plokhotnyuk · 2022-09-20T09:14:46Z

@ybasket @satabin Should I fix "issues" reported by Codacy Static Code Analysis?

Some of them like in README.md are not fixable, others will lead to less efficient or less readable and more error prone code...

satabin · 2022-09-20T09:20:05Z

Hi @plokhotnyuk You can disregard Codacy, their profile is not tuned yet for our usage.

jsoniter-scala/src/main/scala/com/free2move/geoscala/jsoniter_scala.scala

plokhotnyuk · 2022-09-21T08:55:01Z

@ybasket @satabin This PR is ready for final review.

I propose make other improvements for binary compatibility checks and replacement of List by ArraySeq in subsequent PRs

armanbilge · 2022-09-21T13:31:16Z

I propose make other improvements for binary compatibility checks

Just to clarify, the "improvement" is deleting one line :)

geo-scala/build.sbt

Lines 30 to 32 in 876e75c

    
           // disable MiMa until we have proper version released on gnieh / all platforms 
        
           // once removed, the tlBaseVersion has to adjusted as well 
        
           mimaPreviousArtifacts := Set.empty

plokhotnyuk · 2022-09-28T08:39:17Z

@armanbilge I have tried sbt +mimaReportBinaryIssues without mimaPreviousArtifacts := Set.empty line and it doesn't work.

All modules are still unchecked due to empty mimaPreviousArtifacts.

We should set it explicitly, isn't it?

satabin · 2022-09-28T09:34:24Z

Is the base version correctly set?

armanbilge · 2022-09-28T11:34:16Z

@plokhotnyuk yes, that is the correct, expected behavior. Because you have bumped the base version from 0.2 -> 0.3 you have signified that you are making a breaking change, and therefore sbt-typelevel stops checking against previous versions.

You should not update the base version if you want to continue checking against previous versions.

I highly recommend you read the material that I linked you to before :) it explains this in detail, with examples.

https://typelevel.org/sbt-typelevel/faq.html#how-do-i-introduce-breaking-changes-intended-for-my-next-version
https://typelevel.org/sbt-typelevel/faq.html#what-is-a-base-version-anyway

plokhotnyuk · 2022-09-28T11:50:57Z

@armanbilge I don't understand how all the magic should work... Locally when I revert the base version back to 0.2 it doesn't validate any module.

armanbilge · 2022-09-28T11:52:59Z

Have you pulled the tags to your local clone? Otherwise it will be unable to detect previous versions locally (but tags are always present in CI).

armanbilge · 2022-09-28T11:54:04Z

Btw, I see that v0.3.0 is already released. So now I am confused what is happening in your PR.
https://github.com/gnieh/geo-scala/releases/tag/v0.3.0

armanbilge · 2022-09-28T11:56:59Z

For the record: if I leave the tlBaseVersion := "0.3" and I remove the mimaPreviousArtifacts := Set.empty, then it is all configured correctly.

sbt:geo-scala> show mimaPreviousArtifacts
[info] jsoniterScalaJVM / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-jsoniter-scala:0.3.0 (e:info.versionScheme=early-semver))
[info] coreJS / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-core:0.3.0 (e:info.versionScheme=early-semver))
[info] circeNative / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-circe:0.3.0 (e:info.versionScheme=early-semver))
[info] jsoniterScalaJS / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-jsoniter-scala:0.3.0 (e:info.versionScheme=early-semver))
[info] jsoniterScalaNative / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-jsoniter-scala:0.3.0 (e:info.versionScheme=early-semver))
[info] circeJVM / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-circe:0.3.0 (e:info.versionScheme=early-semver))
[info] coreNative / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-core:0.3.0 (e:info.versionScheme=early-semver))
[info] polylineJVM / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-polyline:0.3.0 (e:info.versionScheme=early-semver))
[info] circeJS / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-circe:0.3.0 (e:info.versionScheme=early-semver))
[info] polylineJS / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-polyline:0.3.0 (e:info.versionScheme=early-semver))
[info] coreJVM / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-core:0.3.0 (e:info.versionScheme=early-semver))
[info] polylineNative / mimaPreviousArtifacts
[info]  Set(org.gnieh:geo-scala-polyline:0.3.0 (e:info.versionScheme=early-semver))
[info] mimaPreviousArtifacts
[info]  Set()
sbt:geo-scala>

plokhotnyuk · 2022-09-28T12:09:27Z

It doesn't work for me... Have I missed to run some sbt task?

Details

andriy@notebook:~/Projects/com/github/plokhotnyuk/geo-scala$ sbt
[info] welcome to sbt 1.7.1 (Azul Systems, Inc. Java 17.0.2)
[info] loading global plugins from /home/andriy/.sbt/1.0/plugins
[info] loading settings for project geo-scala-build from plugins.sbt ...
[info] loading project definition from /home/andriy/Projects/com/github/plokhotnyuk/geo-scala/project
[info] loading settings for project root from build.sbt,publish.sbt ...
[info] resolving key references (15836 settings) ...
[info] set scmInfo to https://github.com/plokhotnyuk/geo-scala
[info] set current project to geo-scala (in build file:/home/andriy/Projects/com/github/plokhotnyuk/geo-scala/)
[info] sbt server started at local:///home/andriy/.sbt/1.0/server/0eabc375e6e88395df69/sock
[info] started sbt server
sbt:geo-scala> show mimaPreviousArtifacts
[info] coreJVM / mimaPreviousArtifacts
[info] 	Set()
[info] jsoniterScalaJVM / mimaPreviousArtifacts
[info] 	Set()
[info] circeJS / mimaPreviousArtifacts
[info] 	Set()
[info] coreJS / mimaPreviousArtifacts
[info] 	Set()
[info] polylineNative / mimaPreviousArtifacts
[info] 	Set()
[info] polylineJS / mimaPreviousArtifacts
[info] 	Set()
[info] circeNative / mimaPreviousArtifacts
[info] 	Set()
[info] jsoniterScalaJS / mimaPreviousArtifacts
[info] 	Set()
[info] circeJVM / mimaPreviousArtifacts
[info] 	Set()
[info] jsoniterScalaNative / mimaPreviousArtifacts
[info] 	Set()
[info] polylineJVM / mimaPreviousArtifacts
[info] 	Set()
[info] coreNative / mimaPreviousArtifacts
[info] 	Set()
[info] mimaPreviousArtifacts
[info] 	Set()
sbt:geo-scala> 
[info] shutting down sbt server
andriy@notebook:~/Projects/com/github/plokhotnyuk/geo-scala$ git diff
diff --git a/build.sbt b/build.sbt
index 59a5aa7..0432a9c 100644
--- a/build.sbt
+++ b/build.sbt
@@ -26,10 +26,7 @@ lazy val commonSettings = Seq(
     "org.scalatest" %%% "scalatest" % "3.2.13" % Test,
     "org.scalatestplus" %%% "scalacheck-1-16" % "3.2.13.0" % Test,
     "org.scalacheck" %%% "scalacheck" % "1.16.0" % Test
-  ),
-  // disable MiMa until we have proper version released on gnieh / all platforms
-  // once removed, the tlBaseVersion has to adjusted as well
-  mimaPreviousArtifacts := Set.empty
+  )
 )
 
 lazy val core = crossProject(JVMPlatform, JSPlatform, NativePlatform)

armanbilge · 2022-09-28T12:10:46Z

@plokhotnyuk what is the output of git tag on your system?

plokhotnyuk · 2022-09-28T12:20:49Z

@armanbilge Thanks for the tip! There were no tags in the local clone of my fork until I fetched them from the upstream.

Details

andriy@notebook:~/Projects/com/github/plokhotnyuk/geo-scala$ git tag
andriy@notebook:~/Projects/com/github/plokhotnyuk/geo-scala$ git remote add upstream https://github.com/gnieh/geo-scala
andriy@notebook:~/Projects/com/github/plokhotnyuk/geo-scala$ git remote -v
origin	git@github.com:plokhotnyuk/geo-scala.git (fetch)
origin	git@github.com:plokhotnyuk/geo-scala.git (push)
upstream	https://github.com/gnieh/geo-scala (fetch)
upstream	https://github.com/gnieh/geo-scala (push)
andriy@notebook:~/Projects/com/github/plokhotnyuk/geo-scala$ git fetch upstream
remote: Enumerating objects: 51, done.
remote: Counting objects: 100% (51/51), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 36 (delta 9), reused 35 (delta 9), pack-reused 0
Unpacking objects: 100% (36/36), 5.09 KiB | 473.00 KiB/s, done.
From https://github.com/gnieh/geo-scala
* [new branch]      feature/refresh-versions             -> upstream/feature/refresh-versions
* [new branch]      fix-polyline-on-small-negative-delta -> upstream/fix-polyline-on-small-negative-delta
* [new branch]      geohash                              -> upstream/geohash
* [new branch]      main                                 -> upstream/main
* [new branch]      switch-to-sbt-typelevel              -> upstream/switch-to-sbt-typelevel
* [new branch]      upgrade-to-2.13                      -> upstream/upgrade-to-2.13
* [new tag]         v0.1.0                               -> v0.1.0
* [new tag]         v0.1.0-2023c94f                      -> v0.1.0-2023c94f
* [new tag]         v0.1.0-907d7c6d                      -> v0.1.0-907d7c6d
* [new tag]         v0.1.0-fb77b3a3                      -> v0.1.0-fb77b3a3
* [new tag]         v0.1.1                               -> v0.1.1
* [new tag]         v0.1.2                               -> v0.1.2
* [new tag]         v0.2.0                               -> v0.2.0
* [new tag]         v0.3.0                               -> v0.3.0
andriy@notebook:~/Projects/com/github/plokhotnyuk/geo-scala$ git tag
v0.1.0
v0.1.0-2023c94f
v0.1.0-907d7c6d
v0.1.0-fb77b3a3
v0.1.1
v0.1.2
v0.2.0
v0.3.0

plokhotnyuk · 2022-09-28T12:29:57Z

I bumped the base version to 0.4 due to changes in the circe module that replaced io.circe.Encoder#AsObject by io.circe.Encoder in some pubic methods which were required for passing added serialization assertions in tests.

plokhotnyuk · 2022-09-30T09:04:19Z

@ybasket @satabin Please approve workflow running.

ybasket · 2022-09-30T09:48:53Z

scala/scala#9982 produces some warnings while compiling that are then turned into errors 😢

I downgraded to Scala 2.13.8 to avoid this. I didn't see anything in the release notes of 2.13.9 we would profit from…

ybasket · 2022-09-30T10:05:53Z

@plokhotnyuk thank you for contributing this and your patience with the CI 👍. Would be interested to read that blog article, maybe you throw a link here once ready?

And also thank you 👍, @armanbilge!

I'll release as 0.4.0.

plokhotnyuk force-pushed the main branch 3 times, most recently from 53beacb to aa0763f Compare September 19, 2022 09:03

Update dependencies, add Scala Native support for circe integration, …

c2383d7

…add jsoniter-scala integration

plokhotnyuk force-pushed the main branch from aa0763f to c2383d7 Compare September 19, 2022 09:15

Update tlBaseVersion to 0.3.0

bffae25

ybasket reviewed Sep 19, 2022

View reviewed changes

build.sbt Outdated Show resolved Hide resolved

ybasket and others added 5 commits September 19, 2022 11:35

Update build.sbt

dc72ec8

Update result of sbt githubWorkflowGenerate

2a7f700

Fix compilation errors with Scala 3

6e1ef9f

Disable expected warnings

df255c4

Clean up comments

191f268

plokhotnyuk force-pushed the main branch from d5f4e35 to b48824c Compare September 19, 2022 11:14

armanbilge reviewed Sep 19, 2022

View reviewed changes

build.sbt Outdated Show resolved Hide resolved

build.sbt Outdated Show resolved Hide resolved

plokhotnyuk force-pushed the main branch from b48824c to 4990551 Compare September 19, 2022 11:19

armanbilge reviewed Sep 19, 2022

View reviewed changes

build.sbt Outdated Show resolved Hide resolved

A workaround to build Java 8 bytecode using Java 11

d0870f8

plokhotnyuk force-pushed the main branch from 4990551 to d0870f8 Compare September 19, 2022 11:27

Run githubWorkflowGenerate to reflect JDK versions

876e75c

Add missing checking for } when parsing Geometry types

62919b4

satabin reviewed Sep 20, 2022

View reviewed changes

jsoniter-scala/src/main/scala/com/free2move/geoscala/jsoniter_scala.scala Show resolved Hide resolved

plokhotnyuk added 2 commits September 20, 2022 13:56

Update Scala 2.13.x to 2.13.9

2149dba

Add missing tests for serialization and fix codecs to pass them

df773a9

plokhotnyuk force-pushed the main branch from 78c96d0 to df773a9 Compare September 21, 2022 08:45

Fix formatting

1d684ee

plokhotnyuk added 2 commits September 28, 2022 10:21

Fix compilation error with Scala 2.12.x

300655b

Fix Scala 3 compiler warnings

677d772

Bump the base version and turn on binary compatibility checks

9463a02

ybasket added 2 commits September 30, 2022 11:36

Fix Scala version in workflows

2a32e33

Downgrade to Scala 2.13.8

a3998ed

ybasket merged commit 1592087 into gnieh:main Sep 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies, add Scala Native support for circe integration, add jsoniter-scala integration #7

Update dependencies, add Scala Native support for circe integration, add jsoniter-scala integration #7

plokhotnyuk commented Sep 19, 2022 •

edited

Loading

ybasket commented Sep 19, 2022

plokhotnyuk commented Sep 19, 2022 •

edited

Loading

ybasket commented Sep 19, 2022 •

edited

Loading

plokhotnyuk commented Sep 19, 2022 •

edited

Loading

plokhotnyuk commented Sep 19, 2022

armanbilge commented Sep 19, 2022

plokhotnyuk commented Sep 19, 2022

armanbilge commented Sep 19, 2022

plokhotnyuk commented Sep 19, 2022

armanbilge commented Sep 19, 2022

armanbilge commented Sep 19, 2022

plokhotnyuk commented Sep 20, 2022 •

edited

Loading

satabin commented Sep 20, 2022

plokhotnyuk commented Sep 21, 2022

armanbilge commented Sep 21, 2022

plokhotnyuk commented Sep 28, 2022

satabin commented Sep 28, 2022

armanbilge commented Sep 28, 2022

plokhotnyuk commented Sep 28, 2022

armanbilge commented Sep 28, 2022

armanbilge commented Sep 28, 2022

armanbilge commented Sep 28, 2022 •

edited

Loading

plokhotnyuk commented Sep 28, 2022 •

edited

Loading

armanbilge commented Sep 28, 2022

plokhotnyuk commented Sep 28, 2022 •

edited

Loading

plokhotnyuk commented Sep 28, 2022 •

edited

Loading

plokhotnyuk commented Sep 30, 2022

ybasket commented Sep 30, 2022

ybasket commented Sep 30, 2022

Update dependencies, add Scala Native support for circe integration, add jsoniter-scala integration #7

Update dependencies, add Scala Native support for circe integration, add jsoniter-scala integration #7

Conversation

plokhotnyuk commented Sep 19, 2022 • edited Loading

ybasket commented Sep 19, 2022

plokhotnyuk commented Sep 19, 2022 • edited Loading

ybasket commented Sep 19, 2022 • edited Loading

plokhotnyuk commented Sep 19, 2022 • edited Loading

plokhotnyuk commented Sep 19, 2022

armanbilge commented Sep 19, 2022

plokhotnyuk commented Sep 19, 2022

armanbilge commented Sep 19, 2022

plokhotnyuk commented Sep 19, 2022

armanbilge commented Sep 19, 2022

armanbilge commented Sep 19, 2022

plokhotnyuk commented Sep 20, 2022 • edited Loading

satabin commented Sep 20, 2022

plokhotnyuk commented Sep 21, 2022

armanbilge commented Sep 21, 2022

plokhotnyuk commented Sep 28, 2022

satabin commented Sep 28, 2022

armanbilge commented Sep 28, 2022

plokhotnyuk commented Sep 28, 2022

armanbilge commented Sep 28, 2022

armanbilge commented Sep 28, 2022

armanbilge commented Sep 28, 2022 • edited Loading

plokhotnyuk commented Sep 28, 2022 • edited Loading

armanbilge commented Sep 28, 2022

plokhotnyuk commented Sep 28, 2022 • edited Loading

plokhotnyuk commented Sep 28, 2022 • edited Loading

plokhotnyuk commented Sep 30, 2022

ybasket commented Sep 30, 2022

ybasket commented Sep 30, 2022

plokhotnyuk commented Sep 19, 2022 •

edited

Loading

plokhotnyuk commented Sep 19, 2022 •

edited

Loading

ybasket commented Sep 19, 2022 •

edited

Loading

plokhotnyuk commented Sep 19, 2022 •

edited

Loading

plokhotnyuk commented Sep 20, 2022 •

edited

Loading

armanbilge commented Sep 28, 2022 •

edited

Loading

plokhotnyuk commented Sep 28, 2022 •

edited

Loading

plokhotnyuk commented Sep 28, 2022 •

edited

Loading

plokhotnyuk commented Sep 28, 2022 •

edited

Loading