Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add automatic tooltip repositioning for viewport overflow #108

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brianzhouzc
Copy link
Contributor

@brianzhouzc brianzhouzc commented Nov 12, 2024

Added logic that detects when tooltips would render outside the viewport and automatically flips/updates their position to maintain visibility.

overflow

Related: #7

Added logic that detects when tooltips would render outside the viewport and automatically flips their position to maintain visibility.
@brianzhouzc brianzhouzc requested a review from gnikit as a code owner November 12, 2024 22:52
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee8df97) to head (3a95fb5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #108   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           80        94   +14     
=========================================
+ Hits            80        94   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@brianzhouzc
Copy link
Contributor Author

Added test case for tooltip overflow.

I used the screeninfo package to get monitor information as it supports multiple platforms. AFAIK there's no reliable way to obtain monitor information natively with Tkinter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant