Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

null $shop parameters in config_api_callback #723

Closed
andthink opened this issue Mar 5, 2021 · 2 comments
Closed

null $shop parameters in config_api_callback #723

andthink opened this issue Mar 5, 2021 · 2 comments
Assignees
Labels
bug Bug with the code fix-in-progress In progress

Comments

@andthink
Copy link
Contributor

andthink commented Mar 5, 2021

Expected Behavior

parameter $shop is present in request in config_api_callback

Current Behavior

Apps breaks because $shop is null

Failure Information

I can't manage different store in config_api_callback

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

In admin use config_api_callback to determine different apikeys, sometimes the $shop variable is not defined when changing page.

Proposed PR

#722

@gnikyt
Copy link
Owner

gnikyt commented Mar 11, 2021

@andthink Thanks for the PR, I had to make a couple modifications to have it pass some tests, allowing null values. If you'd like to give the master branch a try via updating composer entry to "dev-master", and seeing if this solves your issue. If so, I'll update contributors file with your username, and release a patch :)

@gnikyt gnikyt self-assigned this Mar 11, 2021
@gnikyt gnikyt added bug Bug with the code fix-in-progress In progress labels Mar 11, 2021
@andthink
Copy link
Contributor Author

Seems everything ok! Thanks

@gnikyt gnikyt closed this as completed Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug with the code fix-in-progress In progress
Projects
None yet
Development

No branches or pull requests

2 participants