Added read shop from referrer if everything fails

[andthink]

when using config_api_callback in configuration sometimes $shop is just null if i click on an internal url of my app, but the information is present in the referrer

[gnikyt]

Thanks! Given this situation can happen with other cases, maybe you can include support for headers too?

If you look at AuthShopify.php::getData, you'll see code that grabs from input (shop query param), headers (x-shop-domain), and referrer.

[andthink]

something like this?

 $requestShop = Arr::get(Request::all(), 'shop');
  parse_str(Request::server('HTTP_REFERER'), $refererQueryParams);
  $refererShop = Arr::get($refererQueryParams,'shop');
  $headerShop = Request::header('X-Shop-Domain');

 $shop = $session ? $session->getShop() : $requestShop  ?? $refererShop ?? $headerShop;

I haven't tested it yet, sorry little busy today

[gnikyt]

The multiple nullcoalescing is a bit hard on the eyes.

My suggestion would be to extract the shop detection into its own private function and have the function return the shop to use.

[andthink]

The multiple nullcoalescing is a bit hard on the eyes.

ahahah ok

My suggestion would be to extract the shop detection into its own private function and have the function return the shop to use.

ok I'll look into it

[andthink]

This was added without me noticing, but isn't it needed?

[gnikyt]

Thats fine!

[andthink]

Ok, I've fixed automatic test errors and added also a parameter to bridge createApp function, without that config_api_callback did not work.
I was working before on version 14 and didn't have this problem, now I've updated and i needed to fix also this

apiKey: '{{ \Osiset\ShopifyApp\getShopifyConfig('api_key', Auth::user()->name ) }}',

[gnikyt]

Ill review now thanks!

[gnikyt]

@andthink Looks good to merge. StyleCI noted the file needs some upduates to match Laravel style: here.

Once you update that, I'll pull and add a couple test cases!

[andthink]

@osiset Done! I still have cookie/session issues in some cases, but I manage with the ?shop= parameter for now.

[andthink]

Found a breaking bug in ShopDomain::fromNative use, please @osiset wait for next UPDATE

[gnikyt]

Sure :)

[darrynten]

this is shockingly dangerous 😱