This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Update ShopModel trait boot method #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the boot method of the trait so that is cannot be overriden by the model implementing the trait while it will automatically be booted by eloquent.
Fix tests
End DocBlock with a dot (.)
|
@osiset tests fixed, let me know if anything is unclear 👍 |
|
@bilfeldt Sorry been busy. Looks great and a very well idea, never thought about this use case. Accepted. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply renames the boot method of the trait
ShopModelso that this method is not accidentally overriden by a boot method set on theUsermodel. This is done by use of Eloquents automatic boot naming conventions for traits - please see this guide by Tighten Co for more information.Without PR:
A
Usermodel using theShopModeltrait might also implement its ownprotected static function boot()which causes the same method on theShopModeltrait to be overriden, causing the global scope to not be registred.With this PR:
A
Usermodel using theShopModeltrait might also implement its ownprotected static function boot()which does not conflict with theShopModeltrait since Eloquent will automatically call the methodbootShopModel()hence causing the global scope to be registred when booting the User model.