Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Normalize composer.json #561

Merged
merged 5 commits into from
Sep 11, 2020
Merged

Normalize composer.json #561

merged 5 commits into from
Sep 11, 2020

Conversation

lucasmichot
Copy link
Collaborator

@lucasmichot lucasmichot commented Aug 28, 2020

Check composer.json normalization in CI workflow: see failing test here https://github.com/osiset/laravel-shopify/pull/561/checks?check_run_id=1040588204#step:6:5


Add support section and extra config to composer.json file and normalize the composer.json file (by running composer normalize)

@lucasmichot lucasmichot changed the title Check composer.json normalization in CI workflow Normalize composer.json Aug 28, 2020
@gnikyt gnikyt added the feature Enhancement to the code label Sep 11, 2020
@gnikyt gnikyt merged commit ec65ef9 into gnikyt:master Sep 11, 2020
@gnikyt
Copy link
Owner

gnikyt commented Sep 11, 2020

Was a small conflict due to previous PR to add Laravel 8 support.
Pulled in your changes, resolved the conflict, re-ran the normalize and seems to be fine now (I hope).
Thanks!

@gnikyt
Copy link
Owner

gnikyt commented Sep 11, 2020

@lucasmichot Any idea why Actions seems odd?

image

The diff doesn't make sense. It appears to be seeing dev requirements inside the standard requirements.

Running composer normalize --dry-run locally produces a positive result. Caching issue somewhere on Github's side maybe?

@lucasmichot
Copy link
Collaborator Author

This seems like a caching issue.
But nothing to worry about.
I guess this will be resolved with a fresh PR on top of master 👍

@gnikyt
Copy link
Owner

gnikyt commented Sep 11, 2020

Confirmed. I've merged in your latest PRs and fixed one minor issue, the action seems to pass now.

@lucasmichot lucasmichot deleted the feature/composer-normalize branch July 16, 2021 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Enhancement to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants