Accelerating and testing point cloud building #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.4.1 to 4.5.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4.4.1...v4.5.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
livaage
force-pushed
the
timing_studies
branch
from
a9e7d2b
to
085d7af
Compare
livaage
changed the title
livaage
changed the title
livaage
changed the title
klieret
approved these changes
Aug 23, 2024
| @@ -38,7 +38,3 @@ jobs: | |||
| - name: Test with pytest | |||
| run: | | |||
| pytest | |||
| - name: Explicitly convert coverage to xml | |||
There was a problem hiding this comment.
I don't think this can possible conflict with the pycharm debugger (but yeah, removing it from the pyproject.toml might be required).
| @@ -1,6 +1,6 @@ | |||
| [tool.pytest.ini_options] | |||
| minversion = "6.0" | |||
| addopts = ["--cov=gnn_tracking", "-ra", "--strict-markers", "--strict-config"] | |||
There was a problem hiding this comment.
You could also do this instead: https://stackoverflow.com/questions/45597357/pycharm-intellij-shows-0-coverage-for-pytest-even-though-coverage-was-generated (I think that's what I did before I switched to vscode)
livaage
force-pushed
the
timing_studies
branch
from
4e1b94b
to
e2aebd4
Compare
livaage
added a commit
to livaage/gnn_tracking
that referenced
this pull request
Aug 28, 2024
Merge pull request gnn-tracking#519 from livaage/timing_studies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #518
feat: Reducing point cloud build runtime by 3x
feat: Added more testing for point cloud building
chore: Removed coverage tests since it conflicted with pycharm's debugger (might solve and add back later)