chore: change proto generate script to apply compatibility patch #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
commented
Aug 19, 2025
zivkovicmilos
approved these changes
Aug 27, 2025
| @@ -15,3 +15,17 @@ for x in ${FILES}; do | |||
| --ts_proto_opt="esModuleInterop=true,forceLong=long,useOptionals=messages,useDate=false,snakeToCamel=false,emitDefaultValues=json-methods" \ | |||
| ${x} | |||
| done | |||
|
|
|||
| # Apply amino JSON compatibility changes to patch proto generated files. | |||
There was a problem hiding this comment.
Can you also make sure this is covered? 🙏
- https://github.com/gnolang/gno-js-client/pull/46/files --> this is an ancient one, but still not fixed core-side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #184
PR changes the proto generate script to apply the changes from #184 to the generated files.
If merged, this is intended as a short term solution until the underlying Amino compatibility issue is discussed and solved.
The caveat of this patch based approach is that it might require some added effort to keep the patch file updated.