Change test to use constants and remove panic

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
gnolang · Oct 4, 2023 · 019c00e · 019c00e
1 parent 8e943c6
commit 019c00e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/gnovm/pkg/gnolang/values_conversions.go b/gnovm/pkg/gnolang/values_conversions.go
@@ -1261,9 +1261,7 @@ func ConvertUntypedBigdecTo(dst *TypedValue, bv BigdecValue, t Type) {
 		if err != nil {
 			panic(fmt.Errorf("cannot convert untyped bigdec to float64: %w", err))
 		}
-		if f64 == 0 && !bd.IsZero() {
-			panic("cannot convert untyped bigdec to float64 -- too close to zero")
-		} else if math.IsInf(f64, 0) {
+		if math.IsInf(f64, 0) {
 			panic("cannot convert untyped bigdec to float64 -- too close to +-Inf")
 		}
 		dst.SetFloat64(f64)

diff --git a/gnovm/tests/testdata/TestMemPackage/success/float_test.gno b/gnovm/tests/testdata/TestMemPackage/success/float_test.gno
@@ -2,9 +2,12 @@ package test
 
 import "testing"
 
-func TestSmallestFloat(t *testing.T) {
-    SmallestNonzeroFloat64 := 0x1p-1022 * 0x1p-52            // 4.9406564584124654417656879286822137236505980e-324
-	DividedByTwo           := SmallestNonzeroFloat64 / 2
+const (
+    SmallestNonzeroFloat64  = 0x1p-1022 * 0x1p-52            // 4.9406564584124654417656879286822137236505980e-324
+	DividedByTwo            = SmallestNonzeroFloat64 / 2
+)
+
 
+func TestSmallestFloat(t *testing.T) {
     println(DividedByTwo)
 }