Skip to content

Commit

Permalink
chore: remove ancient docker integration in misc (#3172)
Browse files Browse the repository at this point in the history
## Description

This PR removes the ancient docker integration test contained in `misc`
that fails, and a random docker compose, also in `misc`.

This test package is actually never even run on `master`, because it
requires a specific build flag `docker` 🤷‍♂️

Closes #3161 

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
</details>
  • Loading branch information
zivkovicmilos authored Nov 25, 2024
1 parent c6f8dd4 commit 2f162b4
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 236 deletions.
20 changes: 9 additions & 11 deletions .github/workflows/misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,15 @@ on:
jobs:
main:
strategy:
fail-fast: false
matrix:
# fixed list because we have some non go programs on that misc folder
program:
- autocounterd
# - devdeps
- docker-integration
- genproto
- genstd
- goscan
- loop
fail-fast: false
matrix:
# fixed list because we have some non go programs on that misc folder
program:
- autocounterd
- genproto
- genstd
- goscan
- loop
name: Run Main
uses: ./.github/workflows/main_template.yml
with:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ require (
golang.org/x/term v0.23.0
golang.org/x/tools v0.24.0
google.golang.org/protobuf v1.35.1
gopkg.in/yaml.v3 v3.0.1
)

require (
Expand All @@ -69,4 +68,5 @@ require (
google.golang.org/genproto/googleapis/api v0.0.0-20240822170219-fc7c04adadcd // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240822170219-fc7c04adadcd // indirect
google.golang.org/grpc v1.65.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
25 changes: 0 additions & 25 deletions misc/docker-compose/docker-compose.yml

This file was deleted.

2 changes: 0 additions & 2 deletions misc/docker-integration/Makefile

This file was deleted.

5 changes: 0 additions & 5 deletions misc/docker-integration/README.md

This file was deleted.

1 change: 0 additions & 1 deletion misc/docker-integration/integration.go

This file was deleted.

191 changes: 0 additions & 191 deletions misc/docker-integration/integration_test.go

This file was deleted.

0 comments on commit 2f162b4

Please sign in to comment.