You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After fix, if a Amino type is not imported through package.
amino_test.go:28: unable to unmarshal with amino, unmarshal to std.Tx failed after 17 bytes (error reading slice contents: unrecognized concrete type full name vm.m_call of map[abci.BlockParams:TypeInfo{Type:abci.BlockParams,Registered:true,PointerPreferred:false,TypeURL:"/abci.BlockParams",ReprType:,Fields:[]amino.FieldInfo{amino.FieldInfo{Type:(*reflect.rtype)(0x104cfc920), TypeInfo:(*amino.TypeInfo)(0x1400011c6e0), Name:"MaxTxBytes", Index:0, ZeroValue:reflect.Value{typ:(*reflect.rtype)(0x104cfc920), ptr:(unsafe.Pointer)(0x105155080), flag:0x86}, UnpackedList:false, FieldOptions:amino.FieldOptions{JSONName:"MaxTxBytes", JSONOmitEmpty:false, BinFixed64:false, BinFixed32:false, BinFieldNum:0x1, Unsafe:false
df37615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the second issue in #1197
Before fix, if a Amino type is not imported through package.
runtime: goroutine stack exceeds 1000000000-byte limit
runtime: sp=0xc02050c458 stack=[0xc02050c000, 0xc04050c000]
fatal error: stack overflow
After fix, if a Amino type is not imported through package.
amino_test.go:28: unable to unmarshal with amino, unmarshal to std.Tx failed after 17 bytes (error reading slice contents: unrecognized concrete type full name vm.m_call of map[abci.BlockParams:TypeInfo{Type:abci.BlockParams,Registered:true,PointerPreferred:false,TypeURL:"/abci.BlockParams",ReprType:,Fields:[]amino.FieldInfo{amino.FieldInfo{Type:(*reflect.rtype)(0x104cfc920), TypeInfo:(*amino.TypeInfo)(0x1400011c6e0), Name:"MaxTxBytes", Index:0, ZeroValue:reflect.Value{typ:(*reflect.rtype)(0x104cfc920), ptr:(unsafe.Pointer)(0x105155080), flag:0x86}, UnpackedList:false, FieldOptions:amino.FieldOptions{JSONName:"MaxTxBytes", JSONOmitEmpty:false, BinFixed64:false, BinFixed32:false, BinFieldNum:0x1, Unsafe:false