Skip to content

Commit

Permalink
chore: typo and comments update
Browse files Browse the repository at this point in the history
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
  • Loading branch information
gfanton committed May 15, 2024
1 parent 1aebe75 commit e0997a5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion gnovm/pkg/gnoamino/packages.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ var Package = amino.RegisterPackage(amino.NewPackage(
"gno",
amino.GetCallersDirname(),
).WithDependencies().WithTypes(
&TypedValueWrapper{}, "gno_value",
&TypedValueWrapper{}, "t_value",
))
6 changes: 3 additions & 3 deletions gnovm/pkg/gnoamino/value_wrapper.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// Most of the methods here are inspired by `gnonative.go` but are now included here for specific reasons:
// Most of the methods here are inspired or copied from `gnonative.go`. They are exported here for several reasons:
// - Methods in `gnonative` are meant for general use and may be removed later, while here they are focused
// on marshaling and unmarshaling only.
// - These methods should be simpler as they don't require the full support of reflection, enabling a more
// detailed implementation.
// - We expect familiarity with the TypedValue type, making its handling easier.
// - We will probably implement Gas comsumtion within those methods.
// - We assume prior knowledge of the type of the TypedValue, simplifying its management.
// - We will likely implement gas consumption calculations within those methods.
package gnoamino

import (
Expand Down
2 changes: 1 addition & 1 deletion gnovm/pkg/gnoamino/value_wrapper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ func TestTypedValueMarshalJSON_Struct(t *testing.T) {
})

t.Run("Marshal", func(t *testing.T) {
raw, err := amino.MarshalJSON(mv)
raw, err := amino.MarshalJSONAny(mv)
require.NoError(t, err)
assert.Equal(t, tc.Expected, string(raw))
})
Expand Down

0 comments on commit e0997a5

Please sign in to comment.