Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_test.gnoweb currently doesn't work (resulting in top-level make test not working) #1222

Closed
thehowl opened this issue Oct 11, 2023 · 2 comments
Closed

_test.gnoweb currently doesn't work (resulting in top-level make test not working) #1222

thehowl opened this issue Oct 11, 2023 · 2 comments
Assignees
@gfanton
Labels
🐞 bug Something isn't working 📦 ⛰️ gno.land Issues or PRs gno.land package related
Milestone
🚀 main.gno.land (...

Comments

@thehowl
Copy link
Member

thehowl commented Oct 11, 2023

This has been untracked for a while. The CI for gnoweb is currently disabled, with the following line:

gno/.github/workflows/gnoland.yml

Line 63 in fa8eb77

#- _test.gnoweb # this test should be rewritten to run an inmemory localnode

I'm making a PR to make make test in gno.land work (by commenting out _test.gnoweb). This should be fixed sometime shortly.
@thehowl thehowl added 🐞 bug Something isn't working 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 11, 2023
@thehowl thehowl added this to the 🚀 main.gno.land (required) milestone Oct 11, 2023
thehowl added a commit that referenced this issue Oct 11, 2023
@thehowl
fix(make): disable _test.gnoweb temporarily
3a47e33 
See-also: #1222
@thehowl thehowl mentioned this issue Oct 11, 2023
Merged
@moul
Copy link
Member

moul commented Oct 20, 2023

See #1241

@moul moul mentioned this issue Oct 20, 2023
Merged
10 tasks
@thehowl
Copy link
Member Author

thehowl commented Nov 7, 2023

Closing as #1241 merged

@thehowl thehowl closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfanton gfanton

Labels
🐞 bug Something isn't working 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
🚀 The Launch [DEPRECATED]
Status: 🚀 Needed for Launch
Milestone
🚀 main.gno.land (required)
Development

No branches or pull requests
3 participants
@moul @thehowl @gfanton