Test fails on dev machine.

[jaekwon]

master, OSX, gnovm test fails.

gnovm % go test ./cmd/... -v -run TestBuild/invalid_go_files
=== RUN   TestBuild
=== RUN   TestBuild/invalid_go_files
=== PAUSE TestBuild/invalid_go_files
=== CONT  TestBuild/invalid_go_files
    testscript.go:534: WORK=$WORK
        PATH=/usr/local/go/bin:/Library/Frameworks/Python.framework/Versions/3.11/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/go/bin:/Users/jk/gopath/bin:/usr/local/go/bin
        GOTRACEBACK=system
        HOME=/var/folders/19/85srrz214qlbd122_0jzskvw0000gn/T/TestBuild3366989911/002
        TMPDIR=$WORK/.tmp
        devnull=/dev/null
        /=/
        :=:
        $=$
        GOCOVERDIR=
        exe=
        GNOROOT=/Users/jk/gopath/src/github.com/gnolang/gno
        
        # Run gno build with invalid go files (0.727s)
        > ! gno build .
        [stderr]
        command-line-arguments
        # command-line-arguments
        ./file1.go:3:1: syntax error: non-declaration statement outside function body
        
        ./.: build pkg: std go compiler: exit status 2
        
        command-line-arguments
        # command-line-arguments
        sub/file2.go:3:1: syntax error: non-declaration statement outside function body
        
        ./sub: build pkg: std go compiler: exit status 2
        
        2 go build errors
        
        [exit status 1]
        > ! stdout .+
        > stderr '\./file1\.go:3:1: syntax error: non-declaration statement outside function body'
        > stderr '\./\.: build pkg: std go compiler: exit status 1'
        FAIL: testdata/gno_build/invalid_go_files.txtar:7: no match for `\./\.: build pkg: std go compiler: exit status 1` found in stderr
        
--- FAIL: TestBuild (0.90s)
    --- FAIL: TestBuild/invalid_go_files (0.73s)

[tbruyelle]

So the reason of the error is because the expected output is exit status 1 and you got exit status 2. Under the hood, gno build executes go build so I assume you have a version of go where the exit code is different, which sounds weird.

What's your go version ?

[tbruyelle]

Command to test this behavior using directly the go command:

 $ rm -rf /tmp/xxx && go run github.com/rogpeppe/go-internal/cmd/txtar-x@latest -C /tmp/xxx ./gnovm/cmd/gno/testdata/gno_build/invalid_go_files.txtar && go build -C /tmp/xxx .; echo $?

Which returns :

# gnobuild
./file1.go:3:1: syntax error: non-declaration statement outside function body
1

We can see the exit code is 1 here.

[jaekwon]

go version go1.19.4 darwin/amd64

% rm -rf /tmp/xxx && go run github.com/rogpeppe/go-internal/cmd/txtar-x@latest -C /tmp/xxx ./gnovm/cmd/gno/testdata/gno_build/invalid_go_files.txtar && go build -C /tmp/xxx .; echo $?

flag provided but not defined: -C
usage: go build [-o output] [build flags] [packages]
Run 'go help build' for details.
2

[jaekwon]

Sounds like we just need a version check for better error messaging.

[tbruyelle]

Fair enough, asserting this exit code doesn't really matter actually, I'll change that.

[tbruyelle]

#1261 should fix the test on your machine :)