Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto deployment of docs not functioning properly #1532

Closed
leohhhn opened this issue Jan 12, 2024 · 3 comments · Fixed by #1564
Closed

Auto deployment of docs not functioning properly #1532

leohhhn opened this issue Jan 12, 2024 · 3 comments · Fixed by #1564
Assignees
@albttx

Comments

@leohhhn
Copy link
Contributor

leohhhn commented Jan 12, 2024

Description

#1468 was merged in Jan 12th 5:13PM GMT+1. The changes are reflected on docs.gno.land soon after.
#1529 was merged in 7 minutes later, but the changes are not live yet as of writing this.

This makes me think that there is an issue with the automatic deployment - perhaps the changes were too close time-wise? Can we look into this?
@zivkovicmilos
Copy link
Member

I think the issue is that the autodeploy cancels the building process if there are no changes to the misc/docusaurus folder:
Capture

@leohhhn
Copy link
Contributor Author

leohhhn commented Jan 14, 2024

This shouldn't be the case; autodeployment should happen if there is any change in the misc/docusaurus, or the docs/ folders.

@albttx can we update this?

@albttx
Copy link
Member

albttx commented Jan 17, 2024

Oh, yeah, since docs/ is ../../ from docusaurus folder, it's not taken, i'll check how to fix that

@zivkovicmilos zivkovicmilos mentioned this issue Jan 22, 2024
Open
@thehowl thehowl mentioned this issue Jan 25, 2024
Merged
7 tasks
thehowl pushed a commit that referenced this issue Jan 25, 2024
@albttx
chore: fix netlify docs deploy (#1564)
42d270a 
This PR force netlify to deploy when there is update on the folder docs/
and misc/docusaurus only.

Fixes #1532

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
leohhhn pushed a commit to leohhhn/gno that referenced this issue Jan 31, 2024
@albttx @leohhhn
chore: fix netlify docs deploy (gnolang#1564)
88c1b9a 
This PR force netlify to deploy when there is update on the folder docs/
and misc/docusaurus only.

Fixes gnolang#1532

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albttx albttx

Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix netlify docs deploy albttx/gno
3 participants
@albttx @zivkovicmilos @leohhhn