-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gnokey] Add support for queries on a specific height #2231
Comments
What are you hoping to query at a specific height? Do you have any hypothetical |
I found it useful to check balances and other things at times when I was writing & testing smart contracts previously. It's not a major usecase, more of a nice-to-have. I think it would be cool to have it, but if you disagree, I think we should remove it from the |
I’m against supporting custom height for balance checking. This is the role of an indexer, like Gnoscan. I suggest making feature requests to them or the DevX team, or consider defining specs for a new indexer. I stay open for other queries such as retrieving a full block or something that’s cheap to compute. |
relate to #2231 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
relate to gnolang#2231 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Description
Currently, calling queries at a specific height is not supported, even though the
--height
flag exists ingnokey
. We should either implement this, or remove the flag until the functionality is implemented. Same goes for the--prove
flag.The text was updated successfully, but these errors were encountered: