Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnoweb: broken CSS styles for italic text #3535

Closed
x1unix opened this issue Jan 17, 2025 · 1 comment · Fixed by #3537
Closed

gnoweb: broken CSS styles for italic text #3535

x1unix opened this issue Jan 17, 2025 · 1 comment · Fixed by #3537
Labels
🐞 bug Something isn't working

Comments

@x1unix
Copy link
Contributor

x1unix commented Jan 17, 2025

Missing default text style for italic text tags

Description

Gnoweb's markdown renderer uses <em> tag to render italic text.
The <em> tag by default has font-style: italic CSS rule.

The problem is that Gnoweb's stylesheet changes default browser styles, causing <em> tag to look like a regular text.

Problematic style declared in .realm-content em CSS selector (see screenshot below).

Your environment

  • Go version: go1.23.4
  • OS and CPU architecture: darwin/arm64
  • Gno commit hash causing the issue: adaafd745113f0bfd27e56b1dfce0df4b5d74aff

Steps to reproduce

  • Create a simple realm to print italic markdown text in Render() function.
func Render() string {
  // or "*sample text*"
  return "_sample text_"
}

Actual behaviour

Image

Current behavior.

Expected behaviour

Image

Italic text is actually italic.

Here I disabled problematic CSS style.

Logs

Please paste any logs here that demonstrate the issue, if they exist

Proposed solution

Fix or remove styles for .realm-content em selector.

@x1unix
Copy link
Contributor Author

x1unix commented Jan 17, 2025

Probably already fixed by @alexiscolin

@x1unix x1unix closed this as completed Jan 17, 2025
jeronimoalbi pushed a commit that referenced this issue Jan 17, 2025
## Description

This PR adjusts display of flagged comments with flow defined in #3480.

Now, flagged comments will be hidden but children replies still be
visible.

### Demo


![image](https://github.com/user-attachments/assets/78dae965-bed7-4fd8-a52e-404afa8bf20a)

> [!IMPORTANT]
> The "comment is hidden" message is actually italic, but [italic font
styles are broken](#3535) in Gnoweb

## Other Changes
In addition to that:

* Fixed Reply URL arguments.
* Added Flag thread/comment URL.
* Started adopting `strings.Builder` instead of string concatenation.

CC @jeronimoalbi 

Closes: #3480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant