Panic in native functions #663
Comments
|
I think we should actually make this slightly different. There could be reasons why the code panics inside of native code for reasons also outside of our control - so I think that when calling native functions, gnovm should guard this with a |
|
So you think there will be cases where a panic doesn't necessarily trigger a How would you identify such cases ? With a specific err/struct passed in the |
tbruyelle
added a commit
to tbruyelle/gno
that referenced
this issue
Apr 6, 2023
Fix gnolang#663 Some panic invoked in native functions should be recoverable from gno code. To do that, `panic` is replaced with `machine.Panic()` which checks first beyond the call stack if there's a recover, before panic-ing.
tbruyelle
added a commit
to tbruyelle/gno
that referenced
this issue
Apr 12, 2023
Fix gnolang#663 Some panic invoked in native functions should be recoverable from gno code. To do that, `panic` is replaced with `machine.Panic()` which checks first beyond the call stack if there's a recover, before panic-ing.
tbruyelle
added a commit
to tbruyelle/gno
that referenced
this issue
Apr 12, 2023
Fix gnolang#663 Some panic invoked in native functions should be recoverable from gno code. To do that, `panic` is replaced with `machine.Panic()` which checks first the call stack if there's a recover, before panic-ing.
jaekwon
pushed a commit
that referenced
this issue
Apr 18, 2023
Fix #663 Some panic invoked in native functions should be recoverable from gno code. To do that, `panic` is replaced with `machine.Panic()` which checks first the call stack if there's a recover, before panic-ing.
peter7891
pushed a commit
that referenced
this issue
May 9, 2023
Fix #663 Some panic invoked in native functions should be recoverable from gno code. To do that, `panic` is replaced with `machine.Panic()` which checks first the call stack if there's a recover, before panic-ing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the panics that are invoked in native functions uses the built-in
panic(), and this is not possible to recover from them in gno code. I think this is wrong and the panic invoked in native functions should be recoverable.This can be fixed by calling
machine.Panicinstead of the built-inpanic. I vote for this change, wdyt ?The text was updated successfully, but these errors were encountered: