Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'gnokey maketx --broadcast' option #112

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

moul
Copy link
Member

@moul moul commented Apr 6, 2022

Changes:

  • added a new —broadcast bool flag on all gnokey maketx subcommands; if set, it will:
    1. Perform a query to detect the account number and sequence
    2. Sign the generated tx
    3. Broadcast the signed tx

Example:

./gno/build/gnokey maketx call moula --pkgpath "gno.land/r/moul_test_0" --func "Inc" --gas-wanted 2000000 --gas-fee 1gnot --broadcast --remote gno.land:36657 --chainid testchain

Result:

$> ./build/gnokey maketx call moula --pkgpath "gno.land/r/moul_test_0" --func "Inc" --gas-wanted 2000000 --gas-fee 1gnot --broadcast --remote gno.land:36657 --chainid testchain
Enter password.
(10 int)
OK!
GAS WANTED: 2000000
GAS USED:   137649

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title WIP feat: add 'gnokey maketx --broadcast' option feat: add 'gnokey maketx --broadcast' option Apr 6, 2022
@moul moul marked this pull request as ready for review April 6, 2022 23:00
@jaekwon
Copy link
Contributor

jaekwon commented Apr 7, 2022

Thank you; the distinction between app and handler is good.

@jaekwon jaekwon merged commit edc78df into gnolang:master Apr 7, 2022
@moul moul deleted the dev/moul/maketx-broadcast branch July 5, 2022 09:16
@moul moul added this to the 🏗1️⃣ test1.gno.land milestone Oct 20, 2022
@moul moul self-assigned this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants