chore: use -coverpkg for extended code coverage reports

[moul]

As discussed during the review meeting.

h/t @thehowl.

[thehowl]

Some weird results:

Any idea why some tests seem to show "decreasing coverage"?

also/ it looks like the YAML from the last PR is invalid: https://app.codecov.io/gh/gnolang/gno/commit/f49e9d03077f7661619791e52a5112d70ea019d9

@moul I saw in the last codecov PR you were complaining about not being able to validate the YAML until merged into master. They actually support validation, but you must do it through a HTTP request to their server:

curl --data-binary @/dev/stdin https://codecov.io/validate << EOF
codecov:
  notify:
    wait_for_ci: false

ignore:
  - misc

comment:
  require_changes: true
[...]
EOF
Error at ['codecov', 'require_changes']:
unknown field

[moul]

Any idea why some tests seem to show "decreasing coverage"?

Maybe the various files are not merged, so the last one only is taken into account for each referenced file?

also/ it looks like the YAML from the last PR is invalid: app.codecov.io/gh/gnolang/gno/commit/f49e9d03077f7661619791e52a5112d70ea019d9

Thanks, fixed with #1137.

@moul I saw in the last codecov PR you were complaining about not being able to validate the YAML until merged into master. They actually support validation, but you must do it through a HTTP request to their server:

Thanks, but I was not talking about validation, but checking the impact of the change itself.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ce258b1) 47.31% compared to head (98bf5c1) 66.57%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1122       +/-   ##
===========================================
+ Coverage   47.31%   66.57%   +19.25%     
===========================================
  Files         367      418       +51     
  Lines       62118    63476     +1358     
===========================================
+ Hits        29394    42260    +12866     
+ Misses      30325    18367    -11958     
- Partials     2399     2849      +450     

see 251 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[moul]

See #1139

[thehowl]

I suspect the pkg1 and pkg2 tests to be failing because enabling coverage reporting on so many packages probably slows them down too much (adding the flag rewrites the code in order to count the lines covered). Obviously we have an issue of the two tests being too slow in general, but I think we might still improve our coverage data with what we actually test by having -coverpkg on gnovm/pkg/gnolang for all tests of package gnovm/tests. (Additionally, the same would probably need to be done for txtar, but we can add that later)

[thehowl]

#1220 (comment)