fix(amino): stack overflow with TypeInfo.String #1180
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 47.00% 47.29% +0.29%
==========================================
Files 365 367 +2
Lines 61156 62118 +962
==========================================
+ Hits 28744 29377 +633
- Misses 30058 30350 +292
- Partials 2354 2391 +37 ☔ View full report in Codecov by Sentry. |
Add a test that demonstrates a bug when the underlying type represented by TypeInfo has fields of the same type: TypeInfo.String() triggers a stack overflow because the codec reuses the same TypeInfo instance when affecting the master TypeInfo.Fields. This happens when cdc.fullnameToTypeInfo is printed (in case of error for instance see codec.go:535), causing all registered TypeInfo to be printed too, which calls their String method. Example of type that can triggers this issue: tm2/pkg/crypto/merkle.SimpleProofNode.
tbruyelle
force-pushed
the
tbruyelle/fix/typeinfo-string
branch
from
d99a462
to
a32def1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR just demonstrates the bug, I didn't find the fix yet
Add a test that demonstrates a bug when the underlying type represented by
TypeInfohas fields of the same type:TypeInfo.String()triggers a stack overflow because the codec reuses the sameTypeInfoinstance when affecting the masterTypeInfo.Fields.This happens when
cdc.fullnameToTypeInfois printed (in case of error for instance see codec.go:535), causing all registeredTypeInfoto be printed too, which calls theirString()method.Example of type that can triggers this issue:
tm2/pkg/crypto/merkle.SimpleProofNodeThis is partly fixed by #1179, but ideally stack overflow should be fixed inside
TypeInfo.String().Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description