-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a Gno2Go precompiler #119
Conversation
13bc316
to
0b46047
Compare
8c7183f
to
62eb2ee
Compare
a084fa1
to
714f80f
Compare
thank you @moul, this looks awesome, though i've yet to read the code yet. I will review by tomorrow when I'm back. |
Sure thing, I'll create a commit for the |
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
714f80f
to
1d2f3dd
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
6354d29
to
0f62310
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
…e executed by standard tools implicitely Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
looks good so far... we probably also want a way to ensure the go version we're checking against, for distributed determinism. |
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
I added it in the list of checkboxes at the top of the PR, so we can remind to do them in a new one. |
Merging in to prevent conflicts; another PR will complete the precompile logic. Thank you @moul. |
This PR is a proposal for https://github.com/gnolang/bounties#10-use-go-typechecker
Official target:
My plan/implementation:
gno.Gno2Go
func.std
withgithub.com/gnolang/gno/stdlibs/stdshim
.gno.land/r/realm
withgithub.com/gnolang/gno/examples/gno.land/r/realm
.tests/go.mod
, no you can safely rungo test -v ./...
from the top-level directory../stdlibs/*
is both used by the.gno
files and also by some.go
files, I decided to rename them to.gno
and create symlinks for each files so thatgo test ./...
can work.gnodev
tool withgnodev precompile ./path/to/package
stdshim
package.Also, I’ve a suggestion: what do about creating a newcmd/gnodev
command, dedicated to contract developers, with tools likeprecompile
,test
and other developer tools?That’s personally what I would love to work with.
Note: the PR is pretty big, because it renames a lot of .go files to .gno; the interesting files here are
gno2go{,_test}.go
.Fixes #107
Related with #121
Closes #113 (replace)