feat: add contribs/gnokeykc #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
+ Coverage 55.71% 56.34% +0.62%
==========================================
Files 421 421
Lines 65554 66792 +1238
==========================================
+ Hits 36525 37635 +1110
- Misses 26169 26258 +89
- Partials 2860 2899 +39
☔ View full report in Codecov by Sentry. |
Signed-off-by: moul <94029+moul@users.noreply.github.com>
github-actions
bot
added
📦 🤖 gnovm
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
thehowl
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
code looks OK and we can iterate on this to improve it, although I must admit I'm not terribly a fan of this approach; my concern is mostly that if we want to add another binary to improve gnokey experience, this is not exactly flexible (we can't easily combine the two).
i'd rather gnokeykc called gnokey through os/exec, though I haven't yet formulated a full proposal regarding how this would work.
one note: maybe add a gh workflow to build contribs/* binaries?
3 tasks
moul
added a commit
to moul/gno
that referenced
this pull request
Nov 14, 2023
## Done - add a `contribs/gnokeykc` wrapper (adding keychain support). - make `tm2/commands.IO` an interface instead of a struct. ## Usage ```console $ gnokeykc kc set Enter password. Successfully added password for key. $ gnokeykc maketx send --send 1ugnot --to g1fsu3z335h5qngf7t3lmakvpmpwg9ae76tqwh7c --chainid test3 --remote test3.gno.land:36657 --gas-fee "1000000ugnot" --gas-wanted "2000000" --broadcast moul OK! GAS WANTED: 2000000 GAS USED: 47072 ``` ## Links - [x] Depends on gnolang#1256 (for contribs/' Makefile & CI) --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
contribs/gnokeykcwrapper (adding keychain support).tm2/commands.IOan interface instead of a struct.Usage
Links