Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ownable-pattern txtar example #1280

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

moul
Copy link
Member

@moul moul commented Oct 22, 2023

The idea is to demonstrate the creation of "capability" libraries that can be used for contracts and objects.

This approach promotes composability for writing concise contracts.
It is recommended to make these libraries available as well-tested packages.

Additionally, it is important to document these packages through dedicated examples (#1046) and a special section in the effective gno documentation (#1000).

Related with #1262
Depends on #1241, #1249 (CI will be red until deps are merged)

Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul moul assigned moul and leohhhn Oct 22, 2023
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c33c9f2) 55.96% compared to head (86521b5) 55.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
- Coverage   55.96%   55.96%   -0.01%     
==========================================
  Files         420      413       -7     
  Lines       65380    64177    -1203     
==========================================
- Hits        36592    35915     -677     
+ Misses      25932    25432     -500     
+ Partials     2856     2830      -26     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul marked this pull request as ready for review November 8, 2023 22:45
@moul moul requested a review from a team as a code owner November 8, 2023 22:45
@moul
Copy link
Member Author

moul commented Nov 8, 2023

@gfanton @deelawn -> can you check if the red CI is related to your recent fix?

@moul moul marked this pull request as draft November 8, 2023 23:01
@gfanton
Copy link
Member

gfanton commented Nov 9, 2023

yes, it's due to a recent change that load the whole example pkg directory at the init for txtar, it was needed by @deelawn for one of his PR. maybe we merge this too fast, sorry about that.

in your case the package /p/demo/ownable already exist in example, so it fail to add it.
some ideas to solve this:

  • use either the orignal package already in example or rename yours.
  • keep the init pure without any package, and have the possibility load them with some argument to gnoland start (or the opposite, with --minimal for example)
  • allow the use of a different namespace for testscripts, like /t/demo/ownable or /p/test/ownable this way we don't interfere with orignal packages while keeping the possibility to import them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Hanging
Status: 📥 Inbox
Status: 🔵 Not Needed for Launch
Development

Successfully merging this pull request may close these issues.

3 participants