Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): add ViM instructions to setup gnols #1282

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

tbruyelle
Copy link
Contributor

@tbruyelle tbruyelle commented Oct 22, 2023

Relates to #1274

What works with this setup:

  • code completion after . but only for stdlibs packages
  • code hover tooltip with :LspHover command (again limited to stdlibs)
  • format on save (only gofmt for now)
  • code Lens with :LspCodeLens command (only when the buffer is _test.gno file) which display a list of possible gno test executions with different scopes (package, files or function).
    Note that test executions are using the LSP workspace/executeCommand and actually vim-lsp doesn't handle well the output of that. That means, tests are running, but you don't get the ouput. I'm still unsure about how to setup that properly (see Feature Request: supports Workspace commands (workspace/executeCommand) prabirshrestha/vim-lsp#1461).

The good thing is the limitations can be removed by contributing to gnols, for instance :

  • Expand code completion to all imported types
  • Expand code hover to all imported types
  • Add the go-to-definition feature
  • Add the rename feature
  • ...

@tbruyelle tbruyelle changed the title doc(vim): add ViM instruction for setup gnols doc(vim): add ViM instructions to setup gnols Oct 22, 2023
@tbruyelle tbruyelle requested review from gfanton and thehowl and removed request for gfanton October 22, 2023 22:01
@thehowl thehowl changed the title doc(vim): add ViM instructions to setup gnols docs(contributing): add ViM instructions to setup gnols Oct 26, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@thehowl thehowl merged commit e10f811 into gnolang:master Oct 27, 2023
5 checks passed
@tbruyelle tbruyelle deleted the tbruyelle/doc/vim-lsp branch October 29, 2023 15:26
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
Relates to gnolang#1274 

What works with this setup:
- code completion after `.` but only for stdlibs packages
- code hover tooltip with `:LspHover` command (again limited to stdlibs)
- format on save (only gofmt for now)
- code Lens with `:LspCodeLens` command (only when the buffer is
`_test.gno` file) which display a list of possible `gno test` executions
with different scopes (package, files or function).
Note that test executions are using the LSP `workspace/executeCommand`
and actually `vim-lsp` doesn't handle well the output of that. That
means, tests are running, but you don't get the ouput. I'm still unsure
about how to setup that properly (see
prabirshrestha/vim-lsp#1461).

The good thing is the limitations can be removed by contributing to
[gnols](https://github.com/gno-playground/gnols), for instance :
- Expand code completion to all imported types
- Expand code hover to all imported types
- Add the *go-to-definition* feature
- Add the *rename* feature
- ...

---------

Co-authored-by: Morgan <git@howl.moe>
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
Relates to gnolang#1274 

What works with this setup:
- code completion after `.` but only for stdlibs packages
- code hover tooltip with `:LspHover` command (again limited to stdlibs)
- format on save (only gofmt for now)
- code Lens with `:LspCodeLens` command (only when the buffer is
`_test.gno` file) which display a list of possible `gno test` executions
with different scopes (package, files or function).
Note that test executions are using the LSP `workspace/executeCommand`
and actually `vim-lsp` doesn't handle well the output of that. That
means, tests are running, but you don't get the ouput. I'm still unsure
about how to setup that properly (see
prabirshrestha/vim-lsp#1461).

The good thing is the limitations can be removed by contributing to
[gnols](https://github.com/gno-playground/gnols), for instance :
- Expand code completion to all imported types
- Expand code hover to all imported types
- Add the *go-to-definition* feature
- Add the *rename* feature
- ...

---------

Co-authored-by: Morgan <git@howl.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants