-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor /r/boards, /p/avl #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaekwon
commented
Apr 21, 2022
- Implement MutTree in /p/avl.
- Refactor boards to use MutTree.
- Render [x] to delete post.
- Test post deletions.
moul
reviewed
Apr 21, 2022
|
||
### Getting started with Emacs | ||
|
||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can manage this one :)
moul
reviewed
Apr 21, 2022
mtree.tree = newtree | ||
return updated | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be one of the tricky cases to be supported in contract migrations; I’ll try to write tests around this.
merging ahead |
moul
pushed a commit
to moul/gno
that referenced
this pull request
Apr 27, 2022
* break up boards into files * fix boards tests * /p/avl *MutTree
moul
added a commit
to gnolang/game-of-realms
that referenced
this pull request
Oct 14, 2023
Actually importing @jaekwon's entries for myself. Original endorsements: - gnolang/gno@474a048 - gnolang/gno@f51d4f8 - gnolang/gno#129 - gnolang/gno@87517c9
moul
added a commit
to gnolang/game-of-realms
that referenced
this pull request
Oct 18, 2023
Actually importing @jaekwon's entries for myself. Original endorsements: - gnolang/gno@474a048 - gnolang/gno@f51d4f8 - gnolang/gno#129 - gnolang/gno@87517c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.