Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor /r/boards, /p/avl #129

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Refactor /r/boards, /p/avl #129

merged 2 commits into from
Apr 22, 2022

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Apr 21, 2022

  • Implement MutTree in /p/avl.
  • Refactor boards to use MutTree.
  • Render [x] to delete post.
  • Test post deletions.


### Getting started with Emacs

TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can manage this one :)

mtree.tree = newtree
return updated
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be one of the tricky cases to be supported in contract migrations; I’ll try to write tests around this.

@jaekwon
Copy link
Contributor Author

jaekwon commented Apr 22, 2022

merging ahead

@jaekwon jaekwon changed the title WIP: Boards edit Refactor /r/boards, /p/avl Apr 22, 2022
@jaekwon jaekwon merged commit affa8e2 into master Apr 22, 2022
moul pushed a commit to moul/gno that referenced this pull request Apr 27, 2022
* break up boards into files
* fix boards tests
* /p/avl *MutTree
@moul moul deleted the boards_edit branch May 9, 2022 20:18
@moul moul added this to the 🏗1️⃣ test1.gno.land milestone Oct 20, 2022
moul added a commit to gnolang/game-of-realms that referenced this pull request Oct 14, 2023
Actually importing @jaekwon's entries for myself.

Original endorsements:
- gnolang/gno@474a048
- gnolang/gno@f51d4f8
- gnolang/gno#129
- gnolang/gno@87517c9
moul added a commit to gnolang/game-of-realms that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants