Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly mark array elements when an realm slice is updated #1305

Merged
merged 16 commits into from
Jan 4, 2024
Merged

fix: properly mark array elements when an realm slice is updated #1305

merged 16 commits into from
Jan 4, 2024

Commits on Jan 4, 2024

  1. recurse on DidUpdate for all ArrayValue elements

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ef7601c View commit details
    Browse the repository at this point in the history

  2. undid incorrect simplification

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    18f224e View commit details
    Browse the repository at this point in the history

  3. reworked solution

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    54a10f3 View commit details
    Browse the repository at this point in the history

  4. Added txtar test

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    833d627 View commit details
    Browse the repository at this point in the history

  5. alternate approach to saving nested reference values

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    36e4d65 View commit details
    Browse the repository at this point in the history

  6. scoped back which types of values can be saved dynamically

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b86e241 View commit details
    Browse the repository at this point in the history

  7. Revert "alternate approach to saving nested reference values" 

    This reverts commit 91b4586.
    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    5903141 View commit details
    Browse the repository at this point in the history

  8. handle nested slices when appending to slices under capacity

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    bcddc78 View commit details
    Browse the repository at this point in the history

  9. wrap new sanity check in debug

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    20bc9e5 View commit details
    Browse the repository at this point in the history

  10. fixed up txtar test

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    06c731e View commit details
    Browse the repository at this point in the history

  11. added XX annotation

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2124d5e View commit details
    Browse the repository at this point in the history

  12. reworked solution to avoid looping in DidUpdate

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ebd1005 View commit details
    Browse the repository at this point in the history

  13. txtar test for 1167 test case

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ba6e747 View commit details
    Browse the repository at this point in the history

  14. improved append test and added more append deep copies

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fcd8249 View commit details
    Browse the repository at this point in the history

  15. handle additional append cases

    @deelawn @jaekwon
    deelawn authored and jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f79703f View commit details
    Browse the repository at this point in the history

  16. DeepCopy -> unrefCopy

    @jaekwon
    jaekwon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    5425504 View commit details
    Browse the repository at this point in the history