feat(p/grc721): add SetTokenURI to IGRC721
#1309
Conversation
github-actions
bot
added
the
🧾 package/realm
irreverentsimplicity
force-pushed
the
feat/grc-721_SetTokenURI
branch
from
ef7a6e3
to
8eaee43
Compare
✅ Deploy Preview for gno-docs2 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1309 +/- ##
==========================================
- Coverage 56.11% 47.14% -8.98%
==========================================
Files 432 372 -60
Lines 65898 61439 -4459
==========================================
- Hits 36978 28963 -8015
- Misses 26036 30097 +4061
+ Partials 2884 2379 -505
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
changed the title
IGRC721
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Morgan <git@howl.moe>
|
I'm adding myself as a reviewer (I believe I developed the initial version, if I'm not mistaken). I'll also need NFTs for transferable memberships and attributes related to DAOs in the future. Please @zivkovicmilos and @thehowl, feel free to review. You can also rely on me, particularly for the "DeFi" part. |
|
LGTM Please clean up the unused error constant, and fix the |
|
thanks, on it |
There was a problem hiding this comment.
Sorry for the late review on this 🙏
Looks good 💯
For reference:
https://eips.ethereum.org/EIPS/eip-721
|
removed unused error message, fixed linting, required checks seems to work |
|
mod-tidy check is failing :) |
|
I just saw, on it |
|
all checks passing now, except 2 Codecov. Not sure how I should go about this, or if there's anything needed on my part? |
|
Stupid codecov. Other failures we get all the time. Going ahead and merging |
|
my first PR merged, wo-hoo! Somewhere there's a beer waiting for me. |
The current grc721 implementation lacks the ability to set the tokenURI metadata for an NFT. There are placheolders inside the struct, but the actual setter was not written. This PR add the following functionality in the `grc` folder inside the `p` folder: - new type grc721 interface for `TokenURI` on top of the existing `TokenID` - new error type in `errors.gno` - SetTokenURI() implementation in `basic_nft.gno` - new test added to `basic_nft_test.gno` AFAIK there are no breaking changes in this PR, tests are passing locally. Let me know any issues. --------- Co-authored-by: Morgan <git@howl.moe>
The current grc721 implementation lacks the ability to set the tokenURI metadata for an NFT. There are placheolders inside the struct, but the actual setter was not written. This PR add the following functionality in the
grcfolder inside thepfolder:TokenURIon top of the existingTokenIDerrors.gnobasic_nft.gnobasic_nft_test.gnoAFAIK there are no breaking changes in this PR, tests are passing locally.
Let me know any issues.