Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort stdlib whitelist #1387

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

harry-hov
Copy link
Contributor

Fix the order of "encoding/json" as it was out of place.

I stumbled over this yesterday. Nothing about this PR is urgent :)

Fix the order of "encoding/json" as it was out of place.
@harry-hov harry-hov requested a review from a team November 20, 2023 19:11
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e2386a) 55.62% compared to head (b3c0c1d) 56.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   55.62%   56.00%   +0.37%     
==========================================
  Files         420      420              
  Lines       65441    65443       +2     
==========================================
+ Hits        36401    36650     +249     
+ Misses      26187    25932     -255     
- Partials     2853     2861       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should eventually be automated: #668

lgtm

@thehowl thehowl merged commit 81be5ac into gnolang:master Nov 23, 2023
187 checks passed
gfanton pushed a commit to moul/gno that referenced this pull request Jan 18, 2024
Fix the order of "encoding/json" as it was out of place.

I stumbled over this yesterday. Nothing about this PR is urgent :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants