feat(sdk/vm): support float as arguments to maketx call

[deelawn]

Addresses #1427

This allows passing in float types to contract functions

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[codecov]

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (d6f0cde) 56.24% compared to head (5db1525) 56.04%.

Files	Patch %	Lines
gno.land/pkg/sdk/vm/convert.go	0.00%	30 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   56.24%   56.04%   -0.21%     
==========================================
  Files         425      439      +14     
  Lines       64428    66182    +1754     
==========================================
+ Hits        36237    37091     +854     
- Misses      25369    26205     +836     
- Partials     2822     2886      +64     

Flag	Coverage Δ
go-1.21.x	∅ <ø> (∅)
misc	∅ <ø> (∅)
misc-_test.genstd	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deelawn]

Discussed with @piux2. Closing due to potential nondeterministic results encoding amino float values:

gno/tm2/pkg/amino/README.md

Line 94 in 968f89e

### Floating points

[deelawn]

Actually this may not be an issue since the float value is encoded as a string when it is sent. I will discuss with @piux2 and reevaluate.

[thehowl]

Basically, looking at this I'm simply wondering why we're doing this argument parsing at all instead of just executing the function as an expression on the GnoVM. Ie. maketx call -func A -args 1 -args 2, to me should just be executed by the VM Keeper as the expression realm.A(1, 2).

I think it's worth chatting with @jaekwon on what could be a good approach here.

[thehowl]

Had a discussion with jae in review call. Posting the details here; tldr is that maketx call arg parsing should be very simple and not call the machine for anything, and the argument distinction be made very clear.

If, however, the float parsing done in convert.go and the one done by the gnovm are the same (so likely, Apd -> apd.Float32/Float64), then it's probably fine.

Call notes

>>> maketx call -func A -args 1 -args 2 <<<

Current approach

- Get A
- Parse each arg individually with a "custom parser" (convert.go)
- Call A with the TypedValue

Suggested approach

- Get A
- A only accepts "safe types"
- Sanitization of arguments based on <func>
- <func> ( <arg1> , <arg2> )
- Machine.RunExpression(string)

-----------------

run -pkgpath gno.land/r/demo/morgan -expr morgan.A(1, 2.4)

run -file 'package main; import "gno.land/r/demo/morgan"; func main() { morgan.A(1, 2.4) }'

Ledger dev: only passes strings
call: strings, integers, bools? (float -- or we do APD -> BasicLit -> TypedValue // we don't use strconv.ParseFloat)

[thehowl]

Looks good for now.

I think we can pick it up at one point and optimise it, as you said, to call strconv.ParseFloat directly. In any case, I'd say we go ahead and merge this :)

[harry-hov]

Just some minor suggestions. Rest LGTM 💯