fix(gnodev): skip failing tx instead of raising an error

[gfanton]

fix #1447

Skip failing TX instead of raising an error.
Also adjust/add some comments in dev node package for better understanding and readability

cc @harry-hov

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[deelawn]

Makes sense to me 👍

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b525e8b) 56.08% compared to head (e4606c6) 56.10%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1456      +/-   ##
==========================================
+ Coverage   56.08%   56.10%   +0.02%     
==========================================
  Files         432      432              
  Lines       66000    66727     +727     
==========================================
+ Hits        37016    37440     +424     
- Misses      26095    26366     +271     
- Partials     2889     2921      +32     

Flag	Coverage Δ
go-1.21.x	∅ <ø> (∅)
misc	∅ <ø> (∅)
misc-_test.genstd	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thehowl]

The changes look good so approving.

I'm wondering though: should an end-user not clearly be able to see any error publishing the specific packages they're publishing?

I get what Hariom is saying in the issue, however if I'm working on a realm and I introduce a bug, I would want gnodev to prominently and clearly tell me what the generated error/panic while publishing the package is.

[harry-hov]

Not sure if my expectations are realistic or not, but I expect output something like:

Case 1: When p/helloworld does not imports avl

$ ~/De/w/gno/examples ❯ gnodev gno.land/r/demo/helloworld
Node            | Listener: tcp://0.0.0.0:36657
[...]
Node            | Loading packages...
Node            | Failed to load `gno.land/p/demo/avl`...
                       - cannot use 0 (untyped int constant) as *Tree value in return statement
Node            | Successfully loaded `gno.land/r/demo/helloworld`...      
Node            | [DONE - with 1 error]

In this case, I can continue working on r/helloworld without need to worry about fixing p/avl

Case 1: When p/helloworld imports avl

$ ~/De/w/gno/examples ❯ gnodev gno.land/r/demo/helloworld
Node            | Listener: tcp://0.0.0.0:36657
[...]
Node            | Loading packages...
Node            | Failed to load `gno.land/p/demo/avl`...
                       - cannot use 0 (untyped int constant) as *Tree value in return statement
Node            | Failed to load `gno.land/r/demo/helloworld`...    
                       - Missing package gno.land/p/demo/avl
Node            | [DONE - with 2 errors]

In this case, since i imports p/avl i need to fix it first before continue working on r/helloworld.

---

We should also add -verbose incase someone wants to see the detailed error msg.

[gfanton]

@harry-hov @thehowl it should be possible, I have an idea on how we can implement this. but I will do this in another PR