chore: HTTP server error handling #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
+ Coverage 55.85% 56.09% +0.23%
==========================================
Files 431 432 +1
Lines 65729 65971 +242
==========================================
+ Hits 36713 37005 +292
+ Misses 26140 26071 -69
- Partials 2876 2895 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
iuricmp
force-pushed
the
chore/gnofaucet-catch-server-error
branch
from
108c5df
to
da82cdb
Compare
gfanton
approved these changes
Jan 5, 2024
thehowl
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
approving & merging these changes as they improve on the current situation; but, judging from discussions on Gno-Core-Contribs, even if not removing gnofaucet, we're likely to be deprecating it in favour of the new faucet.
if you have other features which would aid you for gnofaucet, please make a PR, though I would advise you to work with integrating the new faucet instead.
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
This PR adds a simple error handler for gnofaucet server. We currently have NO feedback on any failure in the gnofaucet HTTP server, which makes troubleshooting more difficult. Imagine the scenario where the port 5050 is already busy! To test: 1 - run gnofaucet in a terminal. 2 - try to run another instance of gnofaucet in a different terminal. 3 - a clear error message is expected on step n2. <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple error handler for gnofaucet server.
We currently have NO feedback on any failure in the gnofaucet HTTP server, which makes troubleshooting more difficult.
Imagine the scenario where the port 5050 is already busy!
To test:
1 - run gnofaucet in a terminal.
2 - try to run another instance of gnofaucet in a different terminal.
3 - a clear error message is expected on step n2.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description