-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(keys/client): prompt user for key name when not provided by user #1540
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1540 +/- ##
=======================================
Coverage 55.91% 55.91%
=======================================
Files 431 431
Lines 65680 65680
=======================================
+ Hits 36722 36727 +5
+ Misses 26080 26076 -4
+ Partials 2878 2877 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@zivkovicmilos tagging you as a reviewer to make sure it's what you wanted, ping me if you want me to do a second review + merge afterwards |
I think you meant to tag @gfanton :) I see the confusion, but Guilhem has a cooler beard. I'll take a look at this PR, thank you for the ping 🙏 |
Agreed. Apologies, lord of the Beard @gfanton 🙏 |
@Halimao I'm really sorry, but after an internal discussion with the team, we've decided not to merge this. Except for the password, we will not prompt the user for anything and prefer the use of flags as the single source of input. |
It's fine😄 |
Refer to #1492 comment
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description