feat(gnovm): Add Basic Code Indentation in REPL

[notJoon]

Description

Indent for code

Updated the code in the REPL to adjust the indent level when an indent rule is detected.

I was considering enhancing the situation where closing parentheses feel tightly attached to the beginning of the previous line. In this case, it seems like setting the terminal to raw mode and directly recognizing the user's key inputs to adjust the level would suffice. (maybe later?)

Example

$ go run ./gnovm/cmd/gno repl

gno> type Foo struct {
...     a int
...     b int
...     }
type Foo struct {
        a       int
        b       int
}

gno> func main() {
...     val := Foo {
...         a: 10,
...         b: 20,
...         }
...     println(val.a + val.b)
...     }
func main() {
        val := Foo{
                a:      10,
                b:      20,
        }
        println(val.a + val.b)
}

gno> main()
30

Add Clear Command

Added the /clear command to clear the repl's screen. For testing, I used dependency injection.

[codecov]

Codecov Report

Attention: Patch coverage is 47.52475% with 53 lines in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (e7e47d2) to head (15e10d2).

Files	Patch %	Lines
gnovm/cmd/gno/repl.go	48.48%	48 Missing and 3 partials ⚠️
gnovm/pkg/repl/repl.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
+ Coverage   54.62%   58.21%   +3.58%     
==========================================
  Files         581      389     -192     
  Lines       77955    65077   -12878     
==========================================
- Hits        42584    37884    -4700     
+ Misses      32194    24377    -7817     
+ Partials     3177     2816     -361     

Flag	Coverage Δ
contribs/gnodev	?
contribs/gnofaucet	?
contribs/gnokeykc	?
contribs/gnomd	?
gno.land	?
gnovm	60.05% <47.52%> (+0.02%)	⬆️
misc/autocounterd	?
misc/genproto	?
misc/genstd	?
misc/goscan	?
misc/logos	?
misc/loop	?
tm2	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deelawn]

Thanks Joon. There are some cases here where the indentation feature exhibits strange behavior when indentation-causing characters are part of string literals rather than the code. Have any ideas how to solve this?

[notJoon]

Memo: Once this PR is merged, I plan to implement the cursor movement and history save/load features proposed in issue #1416. Additionally, to achieve more sophisticated indentation control, I intend to process while keeping the terminal in raw mode, as it requires the ability to read user inputs directly.

[deelawn]

Is this necessary? Things seem to work okay without it.

[notJoon]

Oh, i added that line to test the raw terminal mode. i forget to remove this.

[deelawn]

This change breaks the editor mode. I'd recommend restoring it since it is only called from this one location and moving it to its own function doesn't have too much benefit. The issue can by entering editor mode with /editor and then doing some variable assignments. Notice that editor mode is exited after doing a single variable assignment when it should remain in editor mode until the semicolon is encountered.

[deelawn]

Thanks for the updates. It looks a lot better 👍 . Please see the comments I left. A few things seem to be broken and a couple others unnecessary. The remaining comments are just suggestions.

[notJoon]

Thanks for the updates. It looks a lot better 👍 . Please see the comments I left. A few things seem to be broken and a couple others unnecessary. The remaining comments are just suggestions.

Thank you for the detailed review again. I'll try to get it done as soon as possible this week. 👍👍

[zivkovicmilos]

Hey @notJoon, what's the status on this PR?

Can you please merge in the latest master changes?

[mvertes]

I'm a bit skeptical about this pull request.

The code is redundant with parsing capabilities present elsewhere to analyze the source, and I'm not convinced of its usefulness: if you enter a block with the REPL, it is already reformatted and displayed correctly, even if not indented correctly, as following:

gno> func d() string { return "a" +
...  "b" + "x" }
func d() string {
	return "a" +
		"b" + "x"
}

gno>

[moul]

What about using ast/parser then ast/format?

[notJoon]

What about using ast/parser then ast/format?

That would be practical. I'll ping you after update current code. 👍