fix: incorrect pointer value comparison

gnovm/pkg/gnolang/op_binary.go

@@ -475,7 +475,13 @@ func isEql(store Store, lv, rv *TypedValue) bool {
 				rfv.GetClosure(store)
 		}
 	case PointerKind:
-		// TODO: assumes runtime instance normalization.
+		if lv.V != nil && rv.V != nil {
+			lpv := lv.V.(PointerValue)
+			rpv := rv.V.(PointerValue)
+			if lpv.TV.T == DataByteType && rpv.TV.T == DataByteType {
+				return *(lpv.TV) == *(rpv.TV) && lpv.Base == rpv.Base && lpv.Index == rpv.Index && lpv.Key == rpv.Key
+			}
+		}
 		return lv.V == rv.V
 	default:
 		panic(fmt.Sprintf(

gnovm/pkg/gnolang/values.go

@@ -361,14 +361,15 @@ func (av *ArrayValue) GetPointerAtIndexInt2(store Store, ii int, et Type) Pointe
 			Index: ii,
 		}
 	}
-	bv := &TypedValue{ // heap alloc
+	bv := &TypedValue{ // heap alloc, so need to compare value rather than pointer
 		T: DataByteType,
 		V: DataByteValue{
 			Base:     av,
 			Index:    ii,
 			ElemType: et,
 		},
 	}
+
 	return PointerValue{
 		TV:    bv,
 		Base:  av,

gnovm/pkg/gnolang/values_string.go

@@ -11,7 +11,7 @@ type protectedStringer interface {
 	ProtectedString(*seenValues) string
 }
 
-// This indicates the maximum ancticipated depth of the stack when printing a Value type.
+// This indicates the maximum anticipated depth of the stack when printing a Value type.
 const defaultSeenValuesSize = 32
 
 type seenValues struct {
@@ -322,6 +322,8 @@ func (tv *TypedValue) ProtectedSprint(seen *seenValues, considerDeclaredType boo
 			return fmt.Sprintf("%d", tv.GetUint())
 		case Uint8Type:
 			return fmt.Sprintf("%d", tv.GetUint8())
+		case DataByteType:
+			return fmt.Sprintf("%d", tv.GetDataByte())
 		case Uint16Type:
 			return fmt.Sprintf("%d", tv.GetUint16())
 		case Uint32Type:

gnovm/tests/files/a47.gno

@@ -20,7 +20,9 @@ func main() {
 	println(newArr[0].i, newArr[1].i)
 
 	// The struct should have been copied, not referenced.
-	println(&sArr[2] != &newArr[1])
+	println(&sArr[2] == &newArr[1])
+	// share same underlying array, and same index
+	println(&sArr[1] == &newArr[1])
 }
 
 // Output:
@@ -29,4 +31,5 @@ func main() {
 // 2 3 3
 // true
 // 2 3
+// false
 // true

gnovm/tests/files/a47a.gno

@@ -0,0 +1,24 @@
+package main
+
+type S struct {
+	i int
+}
+
+func main() {
+	sArr := make([]S, 0, 4)
+	sArr = append(sArr, S{1}, S{2}, S{3})
+
+	newArr := append(sArr[:0], sArr[0:]...)
+
+	// share same underlying array
+	println(&sArr[0] == &newArr[0])
+
+	println(&sArr[1] == &newArr[1])
+
+	println(&sArr[2] == &newArr[2])
+}
+
+// Output:
+// true
+// true
+// true

gnovm/tests/files/a47b.gno

@@ -0,0 +1,13 @@
+package main
+
+func main() {
+	s1 := []int{1, 2}
+	i0 := &s1[0]
+	// new array allocated, so they have different base array
+	s1 = append(s1, 3)
+	ii0 := &s1[0]
+	println(i0 == ii0)
+}
+
+// Output:
+// false

gnovm/tests/files/a48.gno

@@ -0,0 +1,31 @@
+package main
+
+func main() {
+	{
+		b := []byte("ABCDEFGHIJKL")
+		a := b
+		println(&b[0] == &a[0], b[0], a[0])
+
+		// modifying the underlying array modifies both a[0] and b[0],
+		// as it should
+		a[0] = 11
+		println(a[0], b[0])
+	}
+
+	{
+		b := []byte{1, 2, 3}
+		a := b
+		println(&b[0] == &a[0], b[0], a[0])
+
+		// modifying the underlying array modifies both a[0] and b[0],
+		// as it should
+		a[0] = 11
+		println(a[0], b[0])
+	}
+}
+
+// Output:
+// true 65 65
+// 11 11
+// true 1 1
+// 11 11

gnovm/tests/files/a48a.gno

@@ -0,0 +1,12 @@
+package main
+
+func main() {
+	{
+		b := []byte("ABCDEFGHIJKL")
+		a := b
+		println(&a[0] == &a[0])
+	}
+}
+
+// Output:
+// true

gnovm/tests/files/a49.gno

@@ -0,0 +1,12 @@
+package main
+
+func main() {
+	c := []byte{'A'}
+	a := c
+	println(&c[0])
+	println(&c[0] == &a[0])
+}
+
+// Output:
+// &(65 uint8)
+// true