Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): prefer Go and Gno for respective language names #1607

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jan 31, 2024

More on my crusade for right terminology and avoid dooming us to have "gnolang" as the official language name.

See-also #1548

@thehowl thehowl requested a review from leohhhn January 31, 2024 12:16
@thehowl thehowl self-assigned this Jan 31, 2024
@thehowl thehowl requested review from jaekwon, moul and a team as code owners January 31, 2024 12:16
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7382d7c) 55.79% compared to head (cf8ebbd) 56.57%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1607      +/-   ##
==========================================
+ Coverage   55.79%   56.57%   +0.78%     
==========================================
  Files         436      438       +2     
  Lines       66168    67094     +926     
==========================================
+ Hits        36917    37961    +1044     
+ Misses      26360    26186     -174     
- Partials     2891     2947      +56     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl changed the title chore: gnolang -> gno chore(examples): prefer Go and Gno for respective language names Feb 1, 2024
@waymobetta waymobetta self-requested a review February 5, 2024 16:24
@kristovatlas
Copy link
Contributor

Makes sense to me.

@thehowl thehowl merged commit 44ee771 into master Feb 5, 2024
188 checks passed
@thehowl thehowl deleted the dev/morgan/its-gno branch February 5, 2024 18:01
@ccomben
Copy link

ccomben commented Feb 6, 2024

Does this mean we need to change previous content to reflect this? There are many places where it's written Gnolang (Gno) and we usually have that in the context of... "Gnolang (Gno) is an interpreted and deterministic version of Golang (Go)."

@thehowl
Copy link
Member Author

thehowl commented Feb 6, 2024

@ccomben ideally, yes, but I would say to prioritise places which are "timeless" (ie. website and docs) and to work on a best-effort basis for "historical" stuff (ie. blog, old tweets). Of course of the latter the blog is the most important (thank you for creating the issue!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants