Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove legacy gnotxsync #1613

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR removes the legacy tool gnotxsync from the codebase, in favor of the new gnolang/tx-archive.

I'm leaving the documentation on using the new tx-archive tool for a separate PR, @leohhhn @waymobetta

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos self-assigned this Feb 1, 2024
@zivkovicmilos zivkovicmilos requested review from moul and a team as code owners February 1, 2024 11:51
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcb3f5d) 56.13% compared to head (3a4f5d8) 56.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
- Coverage   56.13%   56.12%   -0.01%     
==========================================
  Files         438      438              
  Lines       66151    66151              
==========================================
- Hits        37134    37129       -5     
- Misses      26126    26130       +4     
- Partials     2891     2892       +1     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

burn it with fire 🔥

@thehowl thehowl merged commit 371876c into gnolang:master Feb 8, 2024
181 of 183 checks passed
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 8, 2024
## Description

This PR removes the legacy tool `gnotxsync` from the codebase, in favor
of the new [gnolang/tx-archive](https://github.com/gnolang/tx-archive).

I'm leaving the documentation on using the new `tx-archive` tool for a
separate PR, @leohhhn @waymobetta

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@leohhhn leohhhn deleted the feat/remove-gnotxsync branch February 21, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants