feat: swap legacy faucet implementation #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
+ Coverage 44.81% 47.50% +2.69%
==========================================
Files 459 388 -71
Lines 67707 61375 -6332
==========================================
- Hits 30342 29159 -1183
+ Misses 34827 29774 -5053
+ Partials 2538 2442 -96 ☔ View full report in Codecov by Sentry. |
zivkovicmilos
added
the
breaking change
gfanton
requested changes
Mar 11, 2024
|
Well aware some DB tests are failing because of a mod change, looking into it now 🙏 Converting the PR to draft until I sort it EDIT:
|
ajnavarro
requested changes
Mar 14, 2024
gfanton
approved these changes
Mar 14, 2024
ajnavarro
approved these changes
Mar 14, 2024
albttx
pushed a commit
to albttx/gno
that referenced
this pull request
Mar 15, 2024
This PR removes the old faucet implementation to utilize the new [gnolang/faucet](https://github.com/gnolang/faucet). Additional things done: - subnet throttler tidied, made thread safe - gnoweb faucet page fixed (invalid template values) Breaking change: - Gnoweb now interacts with the faucet differently than it did before (POST request instead of a form submission). <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the old faucet implementation to utilize the new gnolang/faucet.
Additional things done:
Breaking change:
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description