chore(gnoclient): Add Send support

[jefft0]

gnoclient already supports MsgCall and MsgRun. This adds Send to support MsgSend.

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (059a3b8) 56.12% compared to head (9633f07) 56.16%.
Report is 6 commits behind head on master.

Files	Patch %	Lines
gno.land/pkg/gnoclient/client_txs.go	85.71%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1639      +/-   ##
==========================================
+ Coverage   56.12%   56.16%   +0.04%     
==========================================
  Files         439      439              
  Lines       66185    66236      +51     
==========================================
+ Hits        37144    37204      +60     
+ Misses      26148    26142       -6     
+ Partials     2893     2890       -3     

Flag	Coverage Δ
go-1.21.x	∅ <ø> (∅)
misc	∅ <ø> (∅)
misc-_test.genstd	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leohhhn]

This looks good, but please add some unit tests 🙏

You can see examples for unit tests with how they're done for Call.

[jefft0]

Hi @leohhhn . I'm not clear on what the unit tests should check. You mention the unit tests using a Mock for Call. These check the response from Call based on the existing code in the genesis.

gno/gno.land/pkg/gnoclient/client_test.go

Line 108 in 2d4f3ae

assert.Equal(t, string(res.DeliverTx.Data), "it works!")

But a MsgSend doesn't have a response. Instead, it changes the state of the blockchain which must be checked by an integration test which can track a state change. This is what I did. Since MsgSend doesn't have a response, what should a unit test do?

[leohhhn]

@jefft0

In that case, I think adding tests that check the validity of the inputs for Send would be great. The tests would show that gnoclient.Send will error out on invalid inputs, instead of allowing for bad input and erroring from the node after sending the transaction.

Something like the following test:

gno/gno.land/pkg/gnoclient/client_test.go

Line 181 in 2d4f3ae

func TestClient_Call_Errors(t *testing.T) {

Btw, while working on implementing this exact testing on the Run in my PR, I found a two small errors with how we validate the configs, for example here (should be == instead of <) & here (should be <=). I've fixed them in my PR, and am now checking out why the tests didn't catch them.

[jefft0]

Thanks for the details. I'll make unit tests to check for error conditions for invalid inputs.

[jefft0]

I added unit tests.