feat(coin.gno): port constructors & more functionality #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
- Coverage 47.48% 44.33% -3.16%
==========================================
Files 385 438 +53
Lines 61408 66007 +4599
==========================================
+ Hits 29159 29263 +104
- Misses 29812 34321 +4509
+ Partials 2437 2423 -14 ☔ View full report in Codecov by Sentry. |
7 tasks
thehowl
pushed a commit
that referenced
this pull request
Apr 24, 2024
## Description This PR ports over the overflow stdlib to Gno. The addition of this library will enable adding Coin functionality already existing in tm2's [coin.go](https://github.com/gnolang/gno/blob/master/tm2/pkg/std/coin.go) the [Coin/Coins](https://github.com/gnolang/gno/blob/master/gnovm/stdlibs/std/coins.gno) in Gno. The tests pass fully, and the library was simply copy-pasted. As per the conversation below, this PR also deprecates/removes the `examples/` package for `overflow`, as it makes more sense to have `overflow` be a part of stdlibs. This will unblock #1696. cc @thehowl <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Hariom Verma <hariom18599@gmail.com>
|
This PR was blocked for quite some time because of the dependency on #1698. I will work on this next week 👍 |
leohhhn
force-pushed
the
feat/better-coins
branch
from
4005e73
to
c1ea95d
Compare
leohhhn
force-pushed
the
feat/better-coins
branch
from
c1ea95d
to
6f4efc6
Compare
7 tasks
leohhhn
added a commit
that referenced
this pull request
May 27, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description This PR ports more functionality from [coin.go](https://github.com/gnolang/gno/blob/master/tm2/pkg/std/coin.go?rgh-link-date=2024-02-27T11%3A01%3A45Z), into Gno (std & stdshim). It will also update the concept & reference docs for Coins. Superseding #1696 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Morgan <morgan@morganbaz.com>
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Jun 3, 2024
) <!-- please provide a detailed description of the changes made in this pull request. --> ## Description This PR ports more functionality from [coin.go](https://github.com/gnolang/gno/blob/master/tm2/pkg/std/coin.go?rgh-link-date=2024-02-27T11%3A01%3A45Z), into Gno (std & stdshim). It will also update the concept & reference docs for Coins. Superseding gnolang#1696 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Morgan <morgan@morganbaz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ports more functionality from coin.go, into Gno (std & stdshim). It will also update the concept & reference docs for Coins.
Depends on #1698Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description