feat: allow disabling consensus WAL #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deelawn
requested review from
gfanton,
jaekwon,
piux2,
moul and
zivkovicmilos
as code owners
github-actions
bot
added
📦 🌐 tendermint v2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1723 +/- ##
=======================================
Coverage 47.47% 47.47%
=======================================
Files 385 385
Lines 61376 61376
=======================================
Hits 29139 29139
Misses 29802 29802
Partials 2435 2435 ☔ View full report in Codecov by Sentry. |
zivkovicmilos
approved these changes
Mar 2, 2024
gfanton
reviewed
Mar 4, 2024
thehowl
approved these changes
Mar 4, 2024
Good one! 😆 (jk, I agree) |
thehowl
reviewed
Mar 8, 2024
albttx
pushed a commit
to albttx/gno
that referenced
this pull request
Mar 15, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> This allows for the consensus state's WAL to be disabled. This is desirable for testing against a running node when we don't care about the WAL -- it avoids potential permissions issues by not writing anything to disk. This allows for our integration testing package to be imported and used outside of the gno repository. <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Morgan <git@howl.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the consensus state's WAL to be disabled. This is desirable for testing against a running node when we don't care about the WAL -- it avoids potential permissions issues by not writing anything to disk. This allows for our integration testing package to be imported and used outside of the gno repository.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description