-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): correct type for shift expression #1775
fix(gnovm): correct type for shift expression #1775
Conversation
…terface_comparison
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for quickly addressing my comments 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR greatly improves the behaviour of the shift operator. The tests are amazing and cover a lot of corner cases (several bugs also found in yaegi thanks to them) and match perfectly the results given by the compiler. Thank you for this effort. My remarks are minor and do no block approval. We should merge it ASAP now.
I see that some tests are not passing, even if they print the correct results. This is due to eval_tests not trimming spaces in results. Let me fix this. |
thanks for the speedy merge @mvertes! <3 |
shift operator where first operand is an untyped bigint always results in a bigint is not resolved by #1426, it's fixed by this one.
=================================================================