Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make r/demo/wugnot compatible with r/demo/users #1782

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Mar 18, 2024

!!! BREAKING CHANGE: data type for wugnot public function's parameter has been changed

Just like foo20 respects a new p/demo/users, fix wugnot to respect it too.

Related #1433 by @harry-hov

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@r3v4s r3v4s requested review from a team as code owners March 18, 2024 05:29
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Mar 18, 2024
@r3v4s r3v4s marked this pull request as draft March 22, 2024 02:39
@r3v4s r3v4s marked this pull request as ready for review March 22, 2024 02:57
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.49%. Comparing base (728f3f2) to head (1b19af9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1782   +/-   ##
=======================================
  Coverage   47.49%   47.49%           
=======================================
  Files         388      388           
  Lines       61305    61305           
=======================================
  Hits        29117    29117           
  Misses      29750    29750           
  Partials     2438     2438           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r3v4s r3v4s force-pushed the fix/wugnot-to-respect-p_users branch from 47e7c3f to c2fc9c6 Compare March 22, 2024 03:48
@r3v4s r3v4s force-pushed the fix/wugnot-to-respect-p_users branch from c2fc9c6 to 1b19af9 Compare March 22, 2024 05:10
@r3v4s r3v4s requested a review from moul as a code owner March 22, 2024 05:10
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Mar 22, 2024
@zivkovicmilos zivkovicmilos added the breaking change Functionality that contains breaking changes label Mar 25, 2024
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@leohhhn leohhhn merged commit 2a06d8e into gnolang:master Apr 17, 2024
187 of 188 checks passed
@leohhhn leohhhn changed the title fix: wugnot-to-respect-p_users fix: make r/demo/wugnot compatible with r/demo/users Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Functionality that contains breaking changes 📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants