-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make r/demo/wugnot
compatible with r/demo/users
#1782
Merged
leohhhn
merged 5 commits into
gnolang:master
from
gnoswap-labs:fix/wugnot-to-respect-p_users
Apr 17, 2024
Merged
fix: make r/demo/wugnot
compatible with r/demo/users
#1782
leohhhn
merged 5 commits into
gnolang:master
from
gnoswap-labs:fix/wugnot-to-respect-p_users
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Tag used for new Realms or Packages.
label
Mar 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1782 +/- ##
=======================================
Coverage 47.49% 47.49%
=======================================
Files 388 388
Lines 61305 61305
=======================================
Hits 29117 29117
Misses 29750 29750
Partials 2438 2438 ☔ View full report in Codecov by Sentry. |
r3v4s
force-pushed
the
fix/wugnot-to-respect-p_users
branch
from
March 22, 2024 03:48
47e7c3f
to
c2fc9c6
Compare
r3v4s
force-pushed
the
fix/wugnot-to-respect-p_users
branch
from
March 22, 2024 05:10
c2fc9c6
to
1b19af9
Compare
github-actions
bot
added
the
📦 ⛰️ gno.land
Issues or PRs gno.land package related
label
Mar 22, 2024
zivkovicmilos
added
the
breaking change
Functionality that contains breaking changes
label
Mar 25, 2024
zivkovicmilos
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
leohhhn
approved these changes
Mar 25, 2024
leohhhn
changed the title
fix: wugnot-to-respect-p_users
fix: make Apr 17, 2024
r/demo/wugnot
compatible with r/demo/users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Functionality that contains breaking changes
📦 ⛰️ gno.land
Issues or PRs gno.land package related
🧾 package/realm
Tag used for new Realms or Packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! BREAKING CHANGE: data type for
wugnot
public function's parameter has been changedJust like
foo20
respects a newp/demo/users
, fixwugnot
to respect it too.Related #1433 by @harry-hov
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description