Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnoweb): Handle unicode characters in 404 page URL #1878

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Apr 3, 2024

Description

Fixed the issue where non-ascii, but valid UTF-8 unicode characters were displayed as percent-encoding text on the 404 page.

@notJoon notJoon requested a review from moul as a code owner April 3, 2024 01:59
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.32%. Comparing base (43b4380) to head (e4ff220).

Files Patch % Lines
gno.land/pkg/gnoweb/gnoweb.go 36.36% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
- Coverage   54.60%   48.32%   -6.29%     
==========================================
  Files         579      409     -170     
  Lines       77896    62680   -15216     
==========================================
- Hits        42539    30293   -12246     
+ Misses      32188    29856    -2332     
+ Partials     3169     2531     -638     
Flag Coverage Δ
contribs/gnodev ?
contribs/gnofaucet ?
contribs/gnokeykc ?
contribs/gnomd ?
gno.land 61.65% <36.36%> (-0.03%) ⬇️
gnovm ?
misc/autocounterd ?
misc/genproto ?
misc/genstd ?
misc/goscan ?
misc/logos ?
misc/loop ?
tm2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon marked this pull request as draft April 3, 2024 02:50
@notJoon notJoon marked this pull request as ready for review April 3, 2024 03:01
@r3v4s
Copy link
Contributor

r3v4s commented Apr 3, 2024

another unicode problems
#1814

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아 보인다 💯

@zivkovicmilos zivkovicmilos merged commit 69f7d13 into gnolang:master Jun 10, 2024
37 of 39 checks passed
@notJoon notJoon deleted the non-ascii-char-in-gno-web-404 branch June 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants