Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(txtar): create user from passed mnemonic, account and index #1879

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

r3v4s
Copy link
Contributor

@r3v4s r3v4s commented Apr 3, 2024

adduser in txtar creates user with bit of randomness which results different address are being added for every time we run txtar testing.

To test SPECIFIC ADDRESS, we need to get rid of randomness

This PR implements adduserfrom, which creates a user from given mnemonic (optionally account and index can be also passed to derive different address from same mnemonic)

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

- mnemonic, account, index can be provided to derive certain address
@r3v4s r3v4s self-assigned this Apr 3, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 47.75%. Comparing base (831bb6f) to head (7e47fd9).

Files Patch % Lines
gno.land/pkg/integration/testing_integration.go 59.52% 10 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1879   +/-   ##
=======================================
  Coverage   47.74%   47.75%           
=======================================
  Files         393      393           
  Lines       61629    61671   +42     
=======================================
+ Hits        29424    29449   +25     
- Misses      29734    29744   +10     
- Partials     2471     2478    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r3v4s r3v4s marked this pull request as ready for review April 3, 2024 02:45
@r3v4s r3v4s requested a review from gfanton as a code owner April 3, 2024 02:45
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you for this great addition! 👌
(just some minor change request)

gno.land/pkg/integration/testing_integration.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/testing_integration.go Outdated Show resolved Hide resolved
gno.land/pkg/integration/testing_integration.go Outdated Show resolved Hide resolved
r3v4s and others added 3 commits April 3, 2024 17:11
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
@r3v4s r3v4s requested a review from gfanton April 3, 2024 08:13
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a minor comment.

@zivkovicmilos zivkovicmilos merged commit c1fd8d5 into gnolang:master Apr 25, 2024
182 of 183 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: No status
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants