-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(txtar): create user from passed mnemonic, account and index #1879
feat(txtar): create user from passed mnemonic, account and index #1879
Conversation
- mnemonic, account, index can be provided to derive certain address
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1879 +/- ##
=======================================
Coverage 47.74% 47.75%
=======================================
Files 393 393
Lines 61629 61671 +42
=======================================
+ Hits 29424 29449 +25
- Misses 29734 29744 +10
- Partials 2471 2478 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thank you for this great addition! 👌
(just some minor change request)
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a minor comment.
adduser
in txtar creates user with bit of randomness which results different address are being added for every time we run txtar testing.This PR implements
adduserfrom
, which creates a user from given mnemonic (optionally account and index can be also passed to derive different address from same mnemonic)Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description