-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(p/avl): increase test coverage #1881
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1881 +/- ##
==========================================
- Coverage 47.79% 45.83% -1.96%
==========================================
Files 393 483 +90
Lines 61643 69268 +7625
==========================================
+ Hits 29463 31752 +2289
- Misses 29708 34888 +5180
- Partials 2472 2628 +156 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few suggestions. Rest LGTM 💯
Thank you for doing this. 🙏
Thank you for the review @harry-hov ! I have resolved all the parts you commented on. Heres the additional modifications:
|
Added one last comment from my side. Otherwise we are good to merge 🙏 |
avl
Package
Description
I added tests to the AVL package.
Checking in Go, the coverage comes out to be 88.6%.