Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(p/avl): increase test coverage #1881

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Apr 3, 2024

Description

I added tests to the AVL package.
Checking in Go, the coverage comes out to be 88.6%.

스크린샷 2024-04-03 오후 3 57 14

@notJoon notJoon requested review from a team as code owners April 3, 2024 06:58
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.83%. Comparing base (35a29a5) to head (1a6845c).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1881      +/-   ##
==========================================
- Coverage   47.79%   45.83%   -1.96%     
==========================================
  Files         393      483      +90     
  Lines       61643    69268    +7625     
==========================================
+ Hits        29463    31752    +2289     
- Misses      29708    34888    +5180     
- Partials     2472     2628     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@harry-hov harry-hov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few suggestions. Rest LGTM 💯

Thank you for doing this. 🙏

examples/gno.land/p/demo/avl/node.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/avl/node.gno Show resolved Hide resolved
examples/gno.land/p/demo/avl/node.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/avl/node.gno Outdated Show resolved Hide resolved
examples/gno.land/p/demo/avl/node.gno Outdated Show resolved Hide resolved
@notJoon
Copy link
Member Author

notJoon commented Apr 12, 2024

Left few suggestions.

Thank you for the review @harry-hov ! I have resolved all the parts you commented on.

Heres the additional modifications:

  • extracted the leaf node insertion logic from the Set function and created a separate setLeaf function.
  • remove stop variable from the TraverseInRange function.

@harry-hov
Copy link
Contributor

Added one last comment from my side. Otherwise we are good to merge 🙏

@harry-hov harry-hov requested a review from leohhhn April 23, 2024 20:03
@harry-hov harry-hov changed the title test(p/avl): Increase Test Coverage for avl Package test(p/avl): increase test coverage Apr 24, 2024
@harry-hov harry-hov merged commit d7fdfe5 into gnolang:master Apr 24, 2024
194 checks passed
@notJoon notJoon deleted the avl-test branch April 24, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants