feat: DAO SDK #1925

n0izn0iz · 2024-04-12T16:50:07Z

This implement a DAO SDK inspired by DA0-DA0

The code in this PR has been extracted from #1154 and cleaned (reviews on the previous PR should have been addressed)

It includes:

Interfaces for the DAO gno.land/p/demo/dao_maker/dao_interfaces
A reference implementation for the core of the DAO gno.land/p/demo/dao_maker/dao_core
A membership-based voting module gno.land/p/demo/dao_maker/dao_voting_group
A single-choice proposal module gno.land/p/demo/dao_maker/dao_proposal_single
An example DAO gno.land/r/demo/dao_maker/dao_realm
A registry to dynamically interact with any registered DAO using it's address gno.land/r/demo/dao_maker/dao_registry

For usage see the tutorial, it is integrated into docusaurus

There is an example membership-based DAO at gno.land/r/demo/teritori/dao_realm that can administer itself and a grc20 token at gno.land/r/demo/teritori/tori

Here is it's GnoWeb Render:

This powers the "Organizations" feature of Teritori dApp on Gno as shown below

The DAO creation UI uses a Gno template and instantiates a new realm.

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: Norman Meier <norman@berty.tech>

moul · 2024-07-07T16:25:31Z

examples/gno.land/p/demo/dao_maker/dao_voting_group/voting_group.gno

+func (v *VotingGroup) Render(path string) string {
+	sb := strings.Builder{}
+	sb.WriteString("Member count: ")
+	sb.WriteString(strconv.FormatUint(uint64(v.MemberCount(havl.Latest)), 10))


Suggested change

sb.WriteString(strconv.FormatUint(uint64(v.MemberCount(havl.Latest)), 10))

sb.WriteString(ufmt.Sprintf("%d", havl.Latest))

moul · 2024-07-07T16:26:37Z

examples/gno.land/p/demo/dao_maker/dao_voting_group/voting_group.gno

+	g.powerByAddr.Iterate(start, end, height, func(k string, v interface{}) bool {
+		if limit > 0 && uint64(len(members)) >= limit {
+			return true
+		}


You can use avl.Tree.IterateByOffset.

moul · 2024-07-07T16:27:21Z

examples/gno.land/p/demo/dao_maker/dao_voting_group/voting_group.gno

+}
+
+func (g *VotingGroup) MemberCount(height int64) uint32 {
+	val, ok := g.memberCount.Get("", height)


isn't avl.Tree.Size enough for you?

moul · 2024-07-07T16:31:31Z

examples/gno.land/r/demo/dao_maker/tori/tori.gno

can you move this to gno.land/r/teritori/tori?

moul · 2024-07-07T17:48:25Z

examples/gno.land/p/demo/dao_maker/dao_interfaces/messages.gno

+type ExecutableMessage interface {
+	ToJSON() *json.Node
+	FromJSON(ast *json.Node)
+
+	String() string
+	Type() string
+}


why is this needed?

moul

There are several interesting aspects in that PR, but there is too much work to review at the moment. Therefore, I will mark it as "request changes" to allow more time for a thorough review.

A high-level suggestion I can provide is to:

Simplify the codebase by reducing the number of packages, files, functions, types, and boilerplate, and avoiding the use of JSON, etc. Consider merging some packages together.
Improve the naming conventions. For instance, use more specific names like "Teritori Realms" and "Daomaker" (a better name could facilitate faster merging, as "Daomaker" is currently too generic and sounds overly official, while "Teritori" would make it easier to integrate).

from gnolang/gno#1925 Signed-off-by: Norman Meier <norman@samourai.coop>

* feat: dao_maker from gnolang/gno#1925 Signed-off-by: Norman Meier <norman@samourai.coop> * tmp Signed-off-by: Norman Meier <norman@samourai.coop> * chore: add back ujson and fix social feed Signed-off-by: Norman Meier <norman@samourai.coop> * chore: remove artifact Signed-off-by: Norman Meier <norman@samourai.coop> * chore: remove artifact Signed-off-by: Norman Meier <norman@samourai.coop> * chore: ci fix Signed-off-by: Norman Meier <norman@samourai.coop> * fix: revert bad change Signed-off-by: Norman Meier <norman@samourai.coop> --------- Signed-off-by: Norman Meier <norman@samourai.coop>

github-actions · 2024-12-08T02:51:11Z

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

moul · 2024-12-08T12:27:57Z

Can you move all the packages under {r,p}/teritori/... and relocate the docs/... into r/teritori/dao_maker/README.md?

I believe we should merge your PR in its current state but under teritori.

Gno2D2 · 2024-12-08T12:28:44Z

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):

SKIP: Do not block the CI for this PR

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)
🟢 The pull request head branch must be up-to-date with its base (more info)

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: TERITORI/gno)
Then
🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request
The pull request head branch must be up-to-date with its base (more info)
If
🟢 Condition met
└── 🟢 On every pull request
Then
🟢 Requirement satisfied
└── 🟢 Head branch (TERITORI:daosdk) is up to date with base (master): behind by 0 / ahead by 121
Manual Checks
**SKIP**: Do not block the CI for this PR
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

Signed-off-by: Norman Meier <norman@samourai.coop>

This PR aims to fix some of remaining UI bugs on gnoweb after the revamp merge. Some of: gnolang#3355 - Fixes Safari select input design and icons - Fixes input hover - Fixes ToC font style - Fixes UI details and improve CSS - Fixes Responsive with long content - Fixes Scrollbar - Fixes fonts loading strategy and size - Fixes ts issue with copy btn (quick clicks) - Fixes some A11y

n0izn0iz · 2024-12-17T18:56:55Z

closing in favor of #3358
will address reviews there

n0izn0iz added 30 commits April 10, 2024 19:11

feat: DA0-DA0 port

f677f1c

Signed-off-by: Norman Meier <norman@berty.tech>

feat: social feed and moderation dao by @hthieu1110

135287a

chore: remove duplicates and unversion packages

6cc1280

Signed-off-by: Norman Meier <norman@berty.tech>

chore: reset gnovm changes

ce2465a

Signed-off-by: Norman Meier <norman@berty.tech>

fix: make social feed and moderation work with latest dao packages

d375b61

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move daodao contracts under teritori dir

d8800be

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move ujson under teritori dir

0fa396f

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move binutils under teritori dir

86d4fcc

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move flags_index under teritori dir

fd7a5b3

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move havl under teritori dir

9c89420

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move markdown_utils under teritori dir

06d722f

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move utf16 under teritori dir

f9f376d

Signed-off-by: Norman Meier <norman@berty.tech>

chore: update modboards golden test

3532d57

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move dao_realm under teritori dir

380f7e7

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move dao_registry under teritori dir

3d12ce1

Signed-off-by: Norman Meier <norman@berty.tech>

chore: fork groups into teritori dir

6a8e185

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move modboards under teritori dir

6ba2ba2

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move social_feeds under teritori dir

3ab1751

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move social_feeds_dao under teritori dir

13b1337

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move tori under teritori dir

b416f44

Signed-off-by: Norman Meier <norman@berty.tech>

chore: update modboards golden test

f320770

Signed-off-by: Norman Meier <norman@berty.tech>

chore: reset gnovm changes

85302e4

Signed-off-by: Norman Meier <norman@berty.tech>

chore: reset .gitignore changes

69dd461

Signed-off-by: Norman Meier <norman@berty.tech>

feat: escrow contract by @go7066

507039d

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move escrow under teritori dir

5a77310

Signed-off-by: Norman Meier <norman@berty.tech>

feat: cosmos-style voting DAO by @go7066

0c01047

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move gnodaos under teritori dir

9e826d7

Signed-off-by: Norman Meier <norman@berty.tech>

chore: add disclaimer in gnodaos

911d788

Signed-off-by: Norman Meier <norman@berty.tech>

feat: justicedao and vrf by @go7066

ea09b63

Signed-off-by: Norman Meier <norman@berty.tech>

chore: move justicedao and vrf under teritori dir

225aa19

Signed-off-by: Norman Meier <norman@berty.tech>

moul reviewed Jul 7, 2024

View reviewed changes

examples/gno.land/r/demo/dao_maker/tori/tori.gno Outdated

Copy link

Member

moul Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this to gno.land/r/teritori/tori?

moul reviewed Jul 7, 2024

View reviewed changes

moul requested changes Jul 8, 2024

View reviewed changes

moul marked this pull request as draft July 8, 2024 01:12

n0izn0iz added a commit to TERITORI/teritori-dapp that referenced this pull request Sep 8, 2024

feat: dao_maker

73b6952

from gnolang/gno#1925 Signed-off-by: Norman Meier <norman@samourai.coop>

n0izn0iz mentioned this pull request Sep 8, 2024

feat: dao_maker TERITORI/teritori-dapp#1267

Merged

github-actions bot added the Stale label Dec 8, 2024

Gno2D2 requested review from a team December 8, 2024 12:28

github-actions bot removed the Stale label Dec 9, 2024

MikaelVallenet and others added 10 commits December 17, 2024 15:42

feat: add update to dao_interfaces

6834121

Merge branch 'master' into daosdk

af91c7f

chore: move everything under teritori namespace

2ca5706

Signed-off-by: Norman Meier <norman@samourai.coop>

fix: remove require and tidy

b690ec0

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: gno fmt

508e831

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: update tori with new grc20 apis

58c1011

Signed-off-by: Norman Meier <norman@samourai.coop>

chore: update usage after interface change

98afc2f

Signed-off-by: Norman Meier <norman@samourai.coop>

Merge branch 'master' into daosdk

1e87380

Merge remote-tracking branch 'origin/master' into daosdk

252b21a

n0izn0iz mentioned this pull request Dec 17, 2024

feat(examples): teritori's dao sdk #3358

Draft

7 tasks

n0izn0iz closed this Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: DAO SDK #1925

feat: DAO SDK #1925

n0izn0iz commented Apr 12, 2024 •

edited

Loading

moul Jul 7, 2024

moul Jul 7, 2024

moul Jul 7, 2024

moul Jul 7, 2024

moul Jul 7, 2024

moul left a comment

github-actions bot commented Dec 8, 2024

moul commented Dec 8, 2024

Gno2D2 commented Dec 8, 2024 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

n0izn0iz commented Dec 17, 2024

	sb.WriteString(strconv.FormatUint(uint64(v.MemberCount(havl.Latest)), 10))
	sb.WriteString(ufmt.Sprintf("%d", havl.Latest))

feat: DAO SDK #1925

feat: DAO SDK #1925

Conversation

n0izn0iz commented Apr 12, 2024 • edited Loading

moul Jul 7, 2024

Choose a reason for hiding this comment

moul Jul 7, 2024

Choose a reason for hiding this comment

moul Jul 7, 2024

Choose a reason for hiding this comment

moul Jul 7, 2024

Choose a reason for hiding this comment

moul Jul 7, 2024

Choose a reason for hiding this comment

moul left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 8, 2024

moul commented Dec 8, 2024

Gno2D2 commented Dec 8, 2024 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

n0izn0iz commented Dec 17, 2024

n0izn0iz commented Apr 12, 2024 •

edited

Loading

Gno2D2 commented Dec 8, 2024 •

edited

Loading