refactor: use jaekwon/testify throughout codebase
#1926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 🌐 tendermint v2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1926 +/- ##
=======================================
Coverage 47.79% 47.79%
=======================================
Files 393 393
Lines 61643 61643
=======================================
Hits 29463 29463
Misses 29708 29708
Partials 2472 2472 ☔ View full report in Codecov by Sentry. |
harry-hov
changed the title
jaekwon/testify throughout codebasestretchr/testify throughout codebase
harry-hov
changed the title
stretchr/testify throughout codebasejaekwon/testify throughout codebase
|
After discussion, we all agreed on using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use 2 implementations of testify in our codebase -
jaekwon/testifyandstretchr/testifyTo streamline our practices and minimize confusion, it's a good idea to opt for a single implementation. Given our preference for jaekwon/testify (see: #777 (comment)), this PR is an attempt to replace
stretchr/testifywithjaekwon/testify.--
Update: After discussion, we all agreed on using
stretchr/testifythroughout our codebase. Superseded by #1931.