feat: gnodev in root make install
#1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
approved these changes
Apr 17, 2024
zivkovicmilos
approved these changes
Apr 18, 2024
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Apr 21, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> ## Description As discussed with @moul, this PR adds `gnodev` to the root Makefile command `make install`. With this, users who are just getting started can simply run `make install` and have a fully working local environment set up, with only one command. I also made the output of the command a bit more readable with some color: <img width="930" alt="Screenshot 2024-04-16 at 13 31 52" src="https://github.com/gnolang/gno/assets/33522493/176c7e0c-529d-4015-9f54-ca2f053dc9ea"> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @moul, this PR adds
gnodevto the root Makefile commandmake install. With this, users who are just getting started can simply runmake installand have a fully working local environment set up, with only one command.I also made the output of the command a bit more readable with some color:
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description